Allowing the package_source to be an Httpurl#582
Merged
ekohl merged 1 commit intotheforeman:masterfrom Mar 3, 2018
Merged
Conversation
|
This is awesome, I had to do the same thing for me... |
ekohl
requested changes
Mar 2, 2018
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Makes sense to me. Could you add a simple test for this so we don't accidentally break this in the future?
Author
|
Not sure where that test shuld go. puppet_agent_install_spec.rb? |
Member
|
Since that doesn't actually check the parameter type I think it needs to go in |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
ekohl
approved these changes
Mar 3, 2018
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
It looks correct. Going to let the tests complete before I merge it (or anyone else does).
MAXxATTAXx
force-pushed
the
HttpUrl_package_source
branch
from
ff987b4 to
1e1d42e
Compare
MAXxATTAXx
force-pushed
the
HttpUrl_package_source
branch
from
1e1d42e to
283fb05
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow httpurl arguments for the pacakge reosurce.
In previous releases this value was not checked and when used with providers like chocolatey, it can support httpurl. The module should not restrict this parameter type so heavily.