Allow arrays for server_jvm_extra_args parameter#596
Merged
ekohl merged 1 commit intotheforeman:masterfrom May 22, 2018
Merged
Conversation
The tests for puppet::server::puppetserver already cover using an array of strings for this parameter, but the base classes forbid it. https://github.com/theforeman/puppet-puppet/blob/ee01cffe239c5080c784d17a37a34742fc7db0fe/spec/classes/puppet_server_puppetserver_spec.rb#L823
ekohl
approved these changes
May 22, 2018
Member
|
Thanks! Letting Travis continue. |
Contributor
Author
|
@ekohl Tests are green. Good to merge? |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for puppet::server::puppetserver already cover using an array
of strings for this parameter, but the base classes forbid it.
puppet-puppet/spec/classes/puppet_server_puppetserver_spec.rb
Line 823 in ee01cff