Remove dynamic and config environments#653
Merged
mmoll merged 1 commit intotheforeman:masterfrom Dec 16, 2018
Merged
Conversation
bastelfreak
reviewed
Nov 18, 2018
Member
bastelfreak
left a comment
bastelfreak
left a comment
There was a problem hiding this comment.
The change itself looks good. One tiny tiny notice: I would update the commit message with something like 'Puppet 4 and newer...'
Member
Author
|
Rephrased. I did consider keeping the env defined type but chose not to in favor of recommending people to store these files in git and deploy either with our git repo (should still work I think) or tools like r10k. |
bastelfreak
approved these changes
Nov 18, 2018
Contributor
|
@ekohl needs a rebase and fixing |
Since Puppet 4 only directory environments are supported so this was mostly dead code.
Member
Author
|
Rebased |
Contributor
|
merged, bedankt @ekohl! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Puppet 4 only directory environments are supported so this was mostly dead code.