run Puppet agent from systemd only after network is brought up#765
Merged
ekohl merged 1 commit intotheforeman:masterfrom Nov 2, 2020
Merged
run Puppet agent from systemd only after network is brought up#765ekohl merged 1 commit intotheforeman:masterfrom
ekohl merged 1 commit intotheforeman:masterfrom
Conversation
Using `After` ensures proper ordering between the Puppet service and the machine's networking. We could also have used `Wants` or `Requires` but, according to the `systemd.unit(5)` manpage, `After` only ensure *ordering*, while `Wants` and `Requires` actually *trigger* units. In other words, `After` ensures that `puppet-run` will be started after networking is up, but will not *necessarily* run when networking is up, nor will it attempt to bring up networking when ran. Closes: theforeman#764
ekohl
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
Afterensures proper ordering between the Puppet service andthe machine's networking. We could also have used
WantsorRequiresbut, according to thesystemd.unit(5)manpage,Afteronly ensure ordering, while
WantsandRequiresactually trigger units.
In other words,
Afterensures thatpuppet-runwill be startedafter networking is up, but will not necessarily run when networking
is up, nor will it attempt to bring up networking when ran.
Closes: #764