Drop config_version and environment.conf#805
Merged
ekohl merged 1 commit intotheforeman:masterfrom Oct 20, 2021
Merged
Conversation
optiz0r
force-pushed
the
drop_config_version
branch
2 times, most recently
from
567b7ee to
21e671c
Compare
optiz0r
added a commit
to optiz0r/puppet-puppet
that referenced
this pull request
Sep 21, 2021
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
optiz0r
added a commit
to optiz0r/puppet-puppet
that referenced
this pull request
Sep 21, 2021
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
Member
|
The unit test failures are odd. I submitted voxpupuli/puppet-systemd#229 which I think should fix them. |
ekohl
approved these changes
Sep 22, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Test suite is not complete yet, but I think the failures that do show up are unrelated.
Member
|
Hmm, looks like the patch was wrong and I need to look at why it's failing. |
ekohl
requested changes
Oct 14, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
You at least need to remove this:
spec/classes/puppet_server_spec.rb
91: it { should_not contain_puppet__config__master('config_version') }
I think after that the test suite should pass.
optiz0r
added a commit
to optiz0r/puppet-puppet
that referenced
this pull request
Oct 14, 2021
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
Support for dynamic and config environments was dropped in a61e010 however the `config_version` related parameters and the `environment.conf` template used by these features were not removed at the same time. This commit drops the unused code. As parameters are being removed, this will be a breaking change and require a major version bump.
optiz0r
force-pushed
the
drop_config_version
branch
from
21e671c to
f51f050
Compare
optiz0r
added a commit
to optiz0r/puppet-puppet
that referenced
this pull request
Oct 14, 2021
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
ekohl
approved these changes
Oct 19, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I kicked off the tests. If they're green(ish, we have some known failures), 👍
Member
|
Thanks! |
optiz0r
added a commit
to optiz0r/puppet-puppet
that referenced
this pull request
Feb 4, 2022
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Directories (whether one, or multiple) are passed as an Array of Stdlib::Absolutepath values. This is a breaking change, as a single string will no longer be accepted. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed. Fixes theforeman#708 Depends on theforeman#805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for dynamic and config environments was dropped in a61e010
however the
config_versionrelated parameters and theenvironment.conftemplate used by these features were not removedat the same time. This commit drops the unused code.
As parameters are being removed, this will be a breaking change and
require a major version bump.