Se corrige el formateador de decimales para que permita enviar más de dos decimales #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se corrige la funcion numberLimit para que no elimine los decimales si el valor es menor a "$decimals"
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
=========================================
Coverage 98.60% 98.60%
Complexity 1306 1306
=========================================
Files 173 173
Lines 5443 5443
=========================================
Hits 5367 5367
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giansalex
approved these changes
Dec 15, 2023
Member
|
@jmanucornejo gracias por la contribución, el cambio se incluyo en la versión v5.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se corrige la funcion numberLimit para que no elimine los decimales si el valor es menor a "$decimals".
Ejemplo:
En algunos casos los XML tienen hasta 10 decimales psoibles. En invoice2.1.xml.tiwg en el PriceAmount se puede ver un caso.
Sin embargo, si envias un número menor (por decir, 6 decimales) la función te devuelve 2 decimales por default, lo que hace imposible enviar más de dos decimales y menos de 10 decimales.
La corrección hace que, si la validación de que tiene más de X decimales es falsa, simplemente de devuela el número original, con los decimales que tenía, sin formatearlo.