Adding inline link support and fixing list issues#1
Conversation
|
@thejimbirch @trjohnst I also needed to use this PR to get my inline links set up. This script is super helpful, especially if you have a static site and your client hands you a Terms of Service doc in Google Docs haha. Can we get this merged? This fixed all my inline link issues. |
|
Unfortunately there are some merge conflicts that need to be addressed first. |
|
Unfortunately master had the same inline link issue. Maybe I’ll take a look
at what you did and create a separate PR if I have the time.
On Mon, Nov 30, 2020 at 1:49 PM Thomas Johnston ***@***.***> wrote:
Also a big thanks from me for this tool, it was super helpful on the
project I used it on!
Sadly I'm pretty short on time to do much merging/test. Although, it looks
like link support may have been added in #2
<#2>. Assuming there's
no more outstanding issues with lists, master may be fine @prkirby
<https://github.com/prkirby>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGGR4P2KU34WCKUYKUZADTSSPZMTANCNFSM4GXJP3JA>
.
--
Regards,
*Paul Kirby*
*Web Developer / Audio Engineer*
*Chicago, IL*
|
|
Hi Everyone, I really appreciate this project and would be happy to contribute. I'm curious, though, whether there's a particular open source license attached to the project (e.g. MIT). |
|
@samhalpert There is not. This is a fork of a repo that I made to fix a few things and I made a pull request back to the author. There is an issue in that queue asking about a license from 2018, but no activity on it. |
|
See oazabir#9 |
|
Thanks! I've followed up on that thread as well. |
I discovered @thejimbirch's fork of GoogleDoc2Html and it was perfect for a project I was working on to transcribe a google doc handed off by a client that needed it as a static HTML page on their site. Because the doc heavily used lists and inline links, I stumbled into a few issues on the HTML export side. This PR aims to fix the issues that I encountered and merge them upstream.