Skip to content

Adding inline link support and fixing list issues#1

Open
trjohnst wants to merge 5 commits into
thejimbirch:masterfrom
trjohnst:master
Open

Adding inline link support and fixing list issues#1
trjohnst wants to merge 5 commits into
thejimbirch:masterfrom
trjohnst:master

Conversation

@trjohnst
Copy link
Copy Markdown

@trjohnst trjohnst commented Feb 13, 2019

I discovered @thejimbirch's fork of GoogleDoc2Html and it was perfect for a project I was working on to transcribe a google doc handed off by a client that needed it as a static HTML page on their site. Because the doc heavily used lists and inline links, I stumbled into a few issues on the HTML export side. This PR aims to fix the issues that I encountered and merge them upstream.

@prkirby
Copy link
Copy Markdown

prkirby commented Nov 30, 2020

@thejimbirch @trjohnst I also needed to use this PR to get my inline links set up. This script is super helpful, especially if you have a static site and your client hands you a Terms of Service doc in Google Docs haha. Can we get this merged? This fixed all my inline link issues.

@thejimbirch
Copy link
Copy Markdown
Owner

Unfortunately there are some merge conflicts that need to be addressed first.

@trjohnst
Copy link
Copy Markdown
Author

Also a big thanks from me for this tool, it was super helpful on the project I used it on!

Sadly I'm pretty short on time to do much merging/test. Although, it looks like link support may have been added in #2. Assuming there's no more outstanding issues with lists, master may be fine @prkirby.

@prkirby
Copy link
Copy Markdown

prkirby commented Nov 30, 2020 via email

@samhalpert
Copy link
Copy Markdown

Hi Everyone,

I really appreciate this project and would be happy to contribute. I'm curious, though, whether there's a particular open source license attached to the project (e.g. MIT).

@thejimbirch
Copy link
Copy Markdown
Owner

@samhalpert There is not. This is a fork of a repo that I made to fix a few things and I made a pull request back to the author. There is an issue in that queue asking about a license from 2018, but no activity on it.

@thejimbirch
Copy link
Copy Markdown
Owner

See oazabir#9

@samhalpert
Copy link
Copy Markdown

Thanks! I've followed up on that thread as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants