-
Notifications
You must be signed in to change notification settings - Fork 12
Revert refresh token changes #4581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: JWT Issuer Mismatch Causes OAuth Failures
The JWT issuer is hardcoded to 'matters.news' instead of using environment.siteDomain. This breaks OAuth token validation and authentication in non-production environments (e.g., development, staging) where the domain differs, as JWTs will have an incorrect issuer claim.
src/connectors/oauthService.ts#L176-L177
matters-server/src/connectors/oauthService.ts
Lines 176 to 177 in f2cc812
| expiresIn: OAUTH_ACCESS_TOKEN_EXPIRES_IN_MS / 1000, | |
| issuer: 'matters.news', |
Bug: Test Password Mismatch Causes Authentication Failures
Test configuration inconsistency: Passwords for defaultTestUser and adminUser were updated to '123' in src/types/__test__/utils.ts, but src/types/__test__/2/auth.test.ts still uses the old password '12345678', leading to authentication test failures.
src/types/__test__/utils.ts#L55-L61
matters-server/src/types/__test__/utils.ts
Lines 55 to 61 in f2cc812
| email: 'test1@matters.news', | |
| password: '123', | |
| userName: 'test1', | |
| } | |
| export const adminUser = { | |
| email: 'admin1@matters.news', | |
| password: '123', |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4581 +/- ##
===========================================
+ Coverage 55.71% 56.40% +0.69%
===========================================
Files 975 973 -2
Lines 19179 19074 -105
Branches 4052 4032 -20
===========================================
+ Hits 10685 10759 +74
+ Misses 7730 7575 -155
+ Partials 764 740 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.