Skip to content

Remove all hardcoded font sizes #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevenjoezhang merged 9 commits into from
Jul 25, 2019
Merged

Remove all hardcoded font sizes #1005

stevenjoezhang merged 9 commits into from
Jul 25, 2019

Conversation

@stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 24, 2019

Two steps

  1. Remove all hardcoded font sizes
  2. Use em instead of px

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Jul 24, 2019

Must be the last PR for font-refacctoring 😂

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 24, 2019

The first one was opened four months ago: #689

@stevenjoezhang stevenjoezhang requested review from 1v9 and jiangtj July 24, 2019 14:50
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 24, 2019
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 24, 2019

Theoretically, this PR does not bring significant visual changes

@stevenjoezhang stevenjoezhang merged commit d944945 into master Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the font branch July 25, 2019 04:13
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 25, 2019
Closed
@1v9
Copy link
Member

1v9 commented Jul 25, 2019

post-title h2 这个把我搞晕了，字体太小了

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 25, 2019

除了Gemini，其它scheme的post-title都设计的比较小

This was referenced Jul 26, 2019
Closed
Closed
Closed
Closed
@1v9 1v9 added the 🌀 Fonts label Aug 13, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Sep 15, 2019
Closed
12 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Remove all hardcoded font sizes (theme-next#1005)
c6ec288
This was referenced Dec 1, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@1v9 1v9 Awaiting requested review from 1v9

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees

No one assigned

Labels

🌀 Fonts 🛠 Improvement 🎯 Roadmap

Projects

None yet

Milestone

v7.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenjoezhang @1v9