Skip to content

Conversation

@jiangtj
Copy link
Member

@jiangtj jiangtj commented Oct 12, 2019

PR Checklist

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the new behavior?

  1. make it has the same key as the configuration file.
  2. support reward_settings.comment in front-matter.
  3. quicklink support more configuration in front-matter.

I think that front-matter having the same keyword as configuration file is a good solution to avoid confusion.

How to use?

In post front-matter:

toc:
  enable: true
  number: false
  max_depth: 3
reward_settings:
  enable: true
  comment: Donate comment here.
quicklink:
  enable: true
  delay: true
  timeout: 3000
  priority: true
  ignores:

# Some deprecated
- toc_max_depth: 4
- toc_number: true
- reward: true
- quicklink: true

Does this PR introduce a breaking change?

  • Yes.
  • No.
quicklink:
  # Home page and archive page can be controlled through home and archive options below.
-  home: true
-  archive: true
+  # This configuration item is independent of `enable`.
+  home: false
+  archive: false

@theme-next theme-next deleted a comment Oct 12, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Oct 14, 2019

https://gitlab.com/JiangTJ/performance-test-hexo/-/jobs/319867428 performance test pass

GitLab
GitLab.com

@jiangtj jiangtj modified the milestones: v7.4.2, v7.5.0 Oct 14, 2019
@theme-next theme-next deleted a comment Oct 14, 2019
@theme-next theme-next deleted a comment Oct 14, 2019
@theme-next theme-next deleted a comment Oct 15, 2019
@stevenjoezhang stevenjoezhang modified the milestones: v7.5.0, v7.4.2 Oct 17, 2019
@theme-next theme-next deleted a comment Oct 18, 2019
@stevenjoezhang stevenjoezhang self-requested a review October 20, 2019 08:33
@theme-next theme-next deleted a comment Oct 23, 2019
@theme-next theme-next deleted a comment Oct 29, 2019
@theme-next theme-next deleted a comment Nov 8, 2019
@stevenjoezhang stevenjoezhang merged commit 4d333ed into master Nov 8, 2019
@stevenjoezhang stevenjoezhang deleted the front-matter branch November 8, 2019 17:38
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
…file (theme-next#1211)

* Refactor front-matter

* Update config file

* Add quicklink support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants