Skip to content

Conversation

@liolok
Copy link
Member

@liolok liolok commented Jul 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

How to use?

In NexT _config.yml:

-  # Internal version: 1.1
+  # Internal version: 1.2.0
  # See: https://github.com/theme-next/theme-next-reading-progress
  # Example:
-  # reading_progress: //cdn.jsdelivr.net/gh/theme-next/theme-next-reading-progress@1/reading_progress.min.js
+  # reading_progress: //cdn.jsdelivr.net/gh/theme-next/theme-next-reading-progress@1.2.0/reading_progress.min.js
  reading_progress:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@liolok liolok added this to the v7.3.0 milestone Jul 3, 2019
@liolok liolok requested review from 1v9, jiangtj and stevenjoezhang July 3, 2019 15:52
@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 July 3, 2019 15:52
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2019

CLA assistant check
All committers have signed the CLA.

@welcome
Copy link

welcome bot commented Jul 3, 2019

Thanks so much for opening your first PR here!

@liolok liolok merged commit b8e4366 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the vendor branch July 3, 2019 17:33
@welcome
Copy link

welcome bot commented Jul 3, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants