Skip to content

Conversation

@stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #758

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 July 4, 2019 23:38
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 4, 2019
@jiangtj
Copy link
Member

jiangtj commented Jul 5, 2019

I think created a new repo, maybe better.

@1v9
Copy link
Member

1v9 commented Jul 5, 2019

Move ## Third party applications to standalone repo.

@stevenjoezhang stevenjoezhang changed the title Create Awesome list Move Third party applications in README.md to standalone repo. Jul 5, 2019
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 5, 2019

@jiangtj @1v9 Do you have any suggestions for naming the new repo? e.g. awesome-theme-next

Or move to theme-next.org ?

@jiangtj
Copy link
Member

jiangtj commented Jul 5, 2019

awesome-theme-next or awesome-next 😂 I prefer the latter.

@sli1989
Copy link
Collaborator

sli1989 commented Jul 5, 2019

what's the meaning of Third party applications in Next
😢

@stevenjoezhang
Copy link
Contributor Author

Commit related to Third party applications:
8cedfbc#diff-04c6e90faac2675aa89e2176d2eec7d8
😢

@jiangtj
Copy link
Member

jiangtj commented Jul 5, 2019

#868 If plug-in, then plug-in can be used as a kind of resource to put here?
And the blog using NexT can also be put here.

@stevenjoezhang
Copy link
Contributor Author

Good idea. I will collect more on this

@stevenjoezhang stevenjoezhang removed this from the v7.3.0 milestone Jul 7, 2019
@stevenjoezhang stevenjoezhang changed the title Move Third party applications in README.md to standalone repo. Create Awesome list Jul 8, 2019
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 9, 2019

@1v9 @jiangtj @sli1989
https://github.com/theme-next/hexo-theme-next/tree/readme
https://github.com/theme-next/hexo-theme-next/tree/readme/docs/zh-CN
https://github.com/theme-next/hexo-theme-next/tree/readme/docs/ru
https://github.com/theme-next/hexo-theme-next/blob/readme/docs/AUTHORS.md

GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.
GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.
GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.
GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.

@1v9
Copy link
Member

1v9 commented Jul 9, 2019

@stevenjoezhang AUTHORS.md is cool but scheme preview spices my eyes, maybe simple link to theme-next.org?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 9, 2019

Do you mean link to theme-next.org in https://github.com/theme-next/awesome-next/blob/master/README.md ?

GitHub
Contribute to theme-next/awesome-next development by creating an account on GitHub.

@1v9
Copy link
Member

1v9 commented Jul 9, 2019

@stevenjoezhang No I was talking about previews in README.md files of NexT.

@stevenjoezhang
Copy link
Contributor Author

@1v9 about preview... I think this image looks fine

@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 9, 2019
@stevenjoezhang stevenjoezhang requested a review from jiangtj July 11, 2019 03:37
@stevenjoezhang
Copy link
Contributor Author

@1v9 Live previews added

@1v9
Copy link
Member

1v9 commented Jul 11, 2019

@stevenjoezhang Do we need political correctness?

60769688-83397500-a105-11e9-9175-e8a1f3597a35.png

@stevenjoezhang
Copy link
Contributor Author

next2

Able to merge now?

@stevenjoezhang stevenjoezhang merged commit aa20bb0 into master Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the readme branch July 11, 2019 16:41
@ivan-nginx
Copy link
Member

ivan-nginx commented Aug 4, 2019

@stevenjoezhang Can we do multilingual support for that preview?

image

2, 4 - on CN, but Language EN setted in Github. Same with RU lang.

image


I mean all 4 screen must be on selected language in Github.

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 20, 2019

I mean all 4 screen must be on selected language in Github.

It's hard to do so - 12 screenshots and 3 photoshop projects. I think this one is OK for multilingual support for the preview:

next-new

next3

@ivan-nginx
Copy link
Member

ivan-nginx commented Aug 27, 2019

It's hard to do so - 12 screenshots and 3 photoshop projects.

Why 12? Just 3 screenshots in result. Can u provide which service u use?

@stevenjoezhang
Copy link
Contributor Author

macOS can only take screenshot of one window at a time (png with alpha channel), so have to use photoshop to combine screenshot of 4 schemes into 1. Maybe this process can also be done in an automated way...

@ivan-nginx
Copy link
Member

I think must be automatic services for that.

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Awesome list

6 participants