Add bounds-checked menu layout builder #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

themuffinator merged 1 commit into main from codex/audit-p_menu_do_update-for-safe-concatenations

Nov 22, 2025

Owner

themuffinator commented Nov 22, 2025

Summary

refactor menu status bar construction to use a bounded helper instead of raw stringstream concatenation
add a reusable P_Menu_BuildStatusBar utility with unit-test fallbacks and header adjustments
cover long menu text with a dedicated unit test to ensure layouts are truncated safely

Testing

g++ -std=c++17 -DUNIT_TESTS -Isrc tests/menu_statusbar_tests.cpp src/p_menu_statusbar.cpp -o /tmp/menu_statusbar_tests
/tmp/menu_statusbar_tests


          Add bounds-checked menu layout builder

fa72747

themuffinator added the codex label

— with

ChatGPT Codex Connector

themuffinator merged commit bc848e4 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels