Skip to content

Conversation

@themuffinator
Copy link
Owner

Summary

  • add a dedicated victor string builder covering team and FFA scenarios
  • wire victor resolution into all intermission HUD displays so winners are consistently shown
  • add unit tests validating the intermission victor string helper

Testing

  • g++ -std=c++17 src/p_hud_victor.cpp src/p_hud_victor_tests.cpp -o /tmp/p_hud_victor_tests
  • /tmp/p_hud_victor_tests

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/themuffinator/muffmode/blob/f316a62d025fb373398a9c62ee4604fb7445ba80/src/p_hud_victor.cpp#L20-L24
P1 Badge Preserve queued intermission victor messages

The new BuildIntermissionVictorString zeroes the output buffer (buffer[0] = '\0';) before checking context.existing_message, but callers pass the same pointer for both (level.intermission_victor_msg). This means any message previously queued in QueueIntermission (timelimit hit, admin-forfeit, mercylimit, etc.) is cleared and the “existing message” branch never runs, so the HUD now replaces the queued reason with auto-computed winner text. Intermission screens will therefore display the wrong end-of-match reason whenever a message was set ahead of time.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants