Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the deprecation of numpy.trapz in NumPy 2.0 by migrating to the replacement function numpy.trapezoid. The PR updates both the code implementation and the minimum NumPy version requirement in the dependencies.
Changes:
- Replaced deprecated
np.trapzwithnp.trapezoidin the WDUD diversity calculation - Updated minimum NumPy version requirement from
>=1.21.2to>=2.0.0 - Updated code comment to reflect the use of
np.trapezoid
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| selector/measures/diversity.py | Replaced deprecated np.trapz with np.trapezoid in the wdud function and updated associated comment |
| requirements.txt | Updated minimum NumPy version from >=1.21.2 to >=2.0.0 to ensure compatibility with the new API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
numpy.trapzwas deprecated since NumPy 2.0 (2023-08-18). Use numpy.trapezoid as replacement.https://github.com/numpy/numpy/blob/f6440be7b8eec4a6481832f15f6730d984d78ef0/doc/source/release/2.4.0-notes.rst#L191