feat: unit tests#139
Merged
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jessicamcinchak
commented
Mar 31, 2022
jessicamcinchak
commented
Mar 31, 2022
jessicamcinchak
commented
Mar 31, 2022
DafyddLlyr
approved these changes
Aug 11, 2022
Contributor
DafyddLlyr
left a comment
DafyddLlyr
left a comment
There was a problem hiding this comment.
Embarrassed by how long it's taken me to write this up sorry...! 😬
Stack looks and feels good, tried writing tests and getting to grips with it and I like it. Totally agree with what you're saying about Cypress for maps and interactions - might be worth testing Cypress here and then seeing how we feel with that vs testcafe in PlanX even?
Anyway - solid work, this adds a lot to the repo and is a great foundation 👏
This was referenced Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying out this stack!
https://vitest.dev/
https://www.npmjs.com/package/happy-dom
https://github.com/vitest-dev/vitest/tree/main/examples/lit
initially tried
@open-wc/testingwithjestfirst which spiraled into a lot of tedious configs (ts, jest, babel etc) and wasn't playing so nice with vite, but that then led me tovitestwhich was very simple to set up (unified config! runs fast!) & has good selection of example repos - including one for Lit - so let's see how it feels!plus a simple github action to automatically run these tests in PRs against
main, starting with this one 🏁closes #52
in the future, maybe we additionally add cyprus for end to end tests, which i think could especially make sense for map interactions? these vitest + cyprus videos (part 1 & 2) seem pretty good, but i haven't watched them through yet