fix: car-sales tutorial — match actual evo-sdk API#6
Open
thepastaclaw wants to merge 1 commit into
Open
Conversation
- contracts.publish(): construct DataContract + IdentitySigner, not simplified fields - documents.create(): construct Document object with proper properties - documents.query(): dataContractId/documentTypeName instead of contractId/documentType - documents.replace(): fetch existing doc, modify, increment revision - doc.properties instead of doc.getData() - contract.id instead of contract.getId() - Identity properties (.publicKeys) instead of methods (.getPublicKeys()) TypeScript compiles clean against @dashevo/evo-sdk@3.1.0-dev.1. Resolves #3
cae3e4e to
55033c0
Compare
Owner
Author
✅ Live Testnet Run — All Steps PassedRan the car sales tutorial end-to-end on testnet with identity Additional issues discovered during live testingThese are NOT just API name mismatches — they would prevent any tutorial from working even with the correct method signatures:
|
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a corrected version of the Car Sales tutorial that compiles against
@dashevo/evo-sdk@3.1.0-dev.1.Changes from original tutorial
contracts.publish(){ identityId, documentSchemas, privateKeyWif }{ dataContract: DataContract, identityKey, signer: IdentitySigner }documents.create(){ contractId, documentType, document: {...} }{ document: new Document({...}), identityKey, signer }documents.query()contractId,documentTypedataContractId,documentTypeNamedocuments.replace(){ documentId, document: {...} }.properties, bump.revisioncontract.getId()contract.id(property getter)doc.getData()doc.propertiesidentity.getPublicKeys()identity.publicKeys(property)npx tsc --noEmitpasses with zero errors.Resolves #3