Merged
Conversation
Collaborator
Noted @keosariel great work! Here a few things to note so you can update the PR accordingly:
Thank you! |
5d81e8c to
2f0716a
Compare
E-wave112
added a commit
that referenced
this pull request
Jul 20, 2022
* improved Importations (#1) * changed test directory * improved exception importation * improved importation * improved importation * fixed importation * added test script * moved constants * moved back * add .db_store to .gitignore * decoupled exceptions * removed .db_store Co-authored-by: kenneth gabriel <keosariel@icloud.com> * upgraded to v0.0.4 Co-authored-by: keosariel <31022243+keosariel@users.noreply.github.com> Co-authored-by: kenneth gabriel <keosariel@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The importation:
Doesn't look great by convention. With my modifications, the importation looks like:
And I also updated the
testsand thereadmeto match the new build. I also removed the test folder, instead of:and I also added a one liner script to run tests