Wasm sdk fix contract version#25
Draft
thephez wants to merge 12 commits into
Draft
Conversation
DataContractWasm was using PlatformVersion::first() which defaults to V0 serialization format that excludes groups and tokens fields. Updated to use the SDK's platform version for proper V1 serialization support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
… methods Remove unsafe platform version fallback from DataContractWasm: - Remove stored &'static PlatformVersion field from struct - Remove From<DataContract> trait implementation using PlatformVersion::first() - Update toJSON method to accept platform_version parameter - Add internal from_data_contract helper for codebase use This ensures platform version is always passed explicitly to methods that require it, following the same pattern as Rust DPP implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace direct Into conversion with from_data_contract method to ensure proper initialization of DataContractWasm wrapper. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
DataContractWasm now stores platform_version internally as u32, ensuring consistent version handling across all operations. The toJSON method no longer requires a platform_version parameter since it uses the stored value. All constructors now require explicit platform version, following the pattern that platform version should never use defaults. BREAKING CHANGE: DataContractWasm.toJSON() no longer accepts a platform_version parameter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.