Skip to content

Add GitHub as a possible CI using Github Actions#1

Open
maxi-k wants to merge 5 commits intothesis-toolbox:masterfrom
maxi-k:master
Open

Add GitHub as a possible CI using Github Actions#1
maxi-k wants to merge 5 commits intothesis-toolbox:masterfrom
maxi-k:master

Conversation

@maxi-k
Copy link
Copy Markdown

@maxi-k maxi-k commented Apr 3, 2020

First of all, thank you so much for the great template!

Now that it has moved from the lrz gitlab to github, I thought I'd contribute the github action configuration I use for building my thesis.

@bithappens
Copy link
Copy Markdown
Contributor

Thanks a lot for your snippet! I would really enjoy removing Circle-CI as the only third party tool and directly use the services provided by the git hosts wherever possible. I was not aware of github actions before and I just added CircleCI to support some "free" CI on github.

That said, I have one major concern with your snippet. So far, all build methods rely on the same docker file raabf/latex-versions:texlive2019. Just to ensure that all package versions and dependencies have the same versions. The action you propose uses xucheng/texlive-full:latest.

I am not sure, which docker image is the better one, but we should use the same for all build methods. With my today's knowledge I would prefer the raabf one. Do you know of any way to change the image used in the github action?

@maxi-k
Copy link
Copy Markdown
Author

maxi-k commented Sep 1, 2020

Good point, I finally got around to creating my own github action which uses the same docker image.
It also uses the Makefile for building the project, which should simplify updates.

Feel free to fork the action into the thesis-toolbox organisation and replacing the respective line in the action definition if you feel that's better in the long run 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants