-
Notifications
You must be signed in to change notification settings - Fork 12
sof-soundwire: split speaker configuration for 2 and 4ch cases #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@RanderWang I could use some help to figure out how to deal with the TGL 2-amp case. we may need a cfg-amp:<1/2/4> string to represent all possible topologies? |
|
@plbossart yes, we can judge amp number by spk number now. I discussed with @bardliao, for static configured codec amp number can be derived from spk number. But for some codecs can be configured dynamically to support different number of spk, cfg-spk doesn't work. We can add cfg-amp in machine driver when we get this dynamic configuration or do it now ? |
I think it's better to add this now, and use it later. Do you want to send a PR for the machine driver? |
yes , thesofproject/linux#2006 |
|
@plbossart As we have supported RT1308-2 in this patch, we should use RT1308.conf instead of RT1308-1.conf in HiFi.conf |
Sorry I don't understand this remark. |
@plbossart I mean in HiFi.conf, should be Now. Maybe this should also be updated in this PR. |
Add tests and separate files for configurations Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
fixed errors reported by @libinyang let's merge and submit PRs against this if it's broken. |
Add tests and separate files for configurations
Fixes: thesofproject/linux#1998
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com