[TGL] runtime PM always in active on TGL chromebook/I2S mode

[keqiaozhang]

Describe the bug
We found this issue on TGL chromebook and only happens with I2S mode. looks like there’s a dependency between SDW driver and runtime PM. if no SDW drivers loaded, runtime PM will always be active.
I also tried to disable SDW in kconfig, but got same results.

To Reproduce
Check runtime PM status when sof is idle for more than 3 seconds.

$cat /sys/bus/pci/devices/0000\:00\:1f.3/power/runtime_status

Reproduction Rate
10/10

Expected behavior
runtime PM will be suspended after sof is idle for more than 3 seconds.

Environment
Driver: fce7f93 + #1971 + https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=914f674bec6efe42f9d6b036850a618fd1698290
Firmware:
SOF branch: tgl-005-drop-stable Commit: 277a9717
TPLG: sof-tgl-max98373-rt5682.tplg

dmesg.txt
logger.txt

[plbossart]

@keqiaozhang please revisit this. If you still have an issue without SoundWire support, then it's not an issue due to SoundWire.

[keqiaozhang]

@keqiaozhang please revisit this. If you still have an issue without SoundWire support, then it's not an issue due to SoundWire.

The interesting thing is that I have 2 TGL Chromebook, these TGL devices support both I2S codec(RT5682I+MAX98373) and SDW codec(RT5682+MAX98373), since coreboot is not yet supported, so we need to override the acpi table for both codecs.
On device-1. we only overrode the acpi table for I2S codec.
On device-2, we overrode the acpi table for both I2S and SDW codecs.
Both devices are connected with I2S codec. then I found that with same kernel(with or without SoundWire support), runtime PM always failed to suspend on device-1 but works well on device-2.

[plbossart]

@keqiaozhang I am not able to parse your description, sorry. can you please use terms like

configuration a): rt5682 in I2S mode, MAX.. in I2S mode, pointer to acpi override table, results.
configuration b),...

thanks

[keqiaozhang]

@plbossart I'm sorry to confuse you.
I will try to make this issue clearly.
First, we found this issue in 5.6.0-rc6+, because latest sof-dev has a regression, kernel 5.7.0 failed to boot on chrome device. please refer to issue #2063.

Let's back to this issue. I did some debugging today and found that this issue only related to DSM, if we set the max98373 codec to feedback mode for DSM pipelines , then runtime PM will always be active. @keyonjie is doing further debugging.

[plbossart]

@keqiaozhang @keyonjie There was a know issue on KBL where the team had to play with the speaker pin to let the amplifier suspend when DSM was used.

@sathya-nujella does this ring a bell?

[sathya-nujella]

@keqiaozhang @keyonjie There was a know issue on KBL where the team had to play with the speaker pin to let the amplifier suspend when DSM was used.

@sathya-nujella does this ring a bell?

KBL issue was there, but it was related to loading of DSM parameters from UCM.
But here in Kequiao's test, it is not UCM.. so not sure same.. but issue details and UCM fix for our reference:

Soraka: Move DSM param loading to Speaker Enable

Loading DSM params from Default Enable prevented
audio pci device from entering RTD3.
Moved the DSM param loading loagically to the speaker
enable section. This ensures Audio device enters RTD3
https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/930346/

[keyonjie]

Thanks for sharing @plbossart @sathya-nujella, that's really good information, looks the speaker switch is the culprit, I am working on understand how it impact to the PCI device.

[naveen-manohar]

Adding @sathyap-chrome

[keyonjie]

So this is actually the expected behavior, we need to add setting/clearing the switch "Left/Right Spk Switch" to the Speaker enable/disable sequence to fix this.

[plbossart]

So this is actually the expected behavior, we need to add setting/clearing the switch "Left/Right Spk Switch" to the Speaker enable/disable sequence to fix this.

where would we add this? In the past it was added in the machine driver so that we wouldn't be adding more things in UCM.