[FEATURE] Support for ES8336 on Intel Comet Lake

[playXE]

Moved from thesofproject/sof

Is your feature request related to a problem? Please describe.
Huawei laptops ship with an Everest ES8336 sound card that is not supported by sofproject.
Describe the solution you'd like
Adding support for it would be really awesome
Describe alternatives you've considered
I already tried this repo which seems to contain a kernel built with support for it but the audio clearly does not work: https://github.com/himozzza/essx8336
Additional context
Booting Linux and trying lsmod or dmsg shows only one valid HDMI sound output on the laptop and nothing more. Here's what I get from Device Manager on Windows:

ACPI\VEN_ESSX&DEV_8336&SUBSYS_152D1262
ACPI\ESSX8336
*ESSX8336

[simas-b]

I just bought Huawei Matebook d15 i3-10110U and can confirm the sound does not work (Dummy output shown as Output device).

OS: Ubuntu 22.04 (development branch)
Kernel 5.15.0-051500rc7-generic

Also tried the same kernel as @playXE linked https://github.com/himozzza/essx8336. After booting with it It displayed "Intel Corporation Comet Lake PCH-LP cAVS" as Output device and it correctly prompted me to select between "Headset" and "Headphones" when I plugged in headpone jack, but there was no sound neither on builtin speaker or headpones.
I could not hear any sound with speaker-test utility.

This is my alsa-info: http://alsa-project.org/db/?f=95f73cdf9497ae38f36b4e12646d74826fbecdba

Bluetooth audio works great.

Thank you

[plbossart]

Thanks for reporting this @Simonboot and @playXE . We are indeed missing quirks for this CML device.

Can you retry with the branch https://github.com/plbossart/sound/tree/fix/es8336-codec

You should boot the DSP and reach the point where a topology file is missing.

You will have to try each of the files in this zip
cml.tar.gz

Please try with sof-cml-es8336-0.tplg copied as /lib/firmware/intel/sof-tplg/sof-cml-es8336.tplg, then 1 and 2. We need this trial-and-error method to figure out where the codec is attached to (I2S/SSP interface 0 1 or 2).

[plbossart]

forgot to add @hli25 on this one, not sure if you can help with the SSP connection - which SSP should be used on CML-based devices?

[playXE]

atm I am running Windows on my laptop, is there any way to load this kernel with USB drive? Maybe compile kernel on WSL and then move it to bootable USB?

[playXE]

@plbossart I am trying to build kernel in WSL and it fails:

➜  sound git:(fix/es8336-codec) make -j6
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  HOSTCC  scripts/conmakehash
  HOSTCC  scripts/sortextable
  CHK     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/selinux/genheaders/genheaders
  HOSTCC  scripts/selinux/mdp/mdp
In file included from scripts/selinux/mdp/mdp.c:49:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
  245 | #error New address family defined, please update secclass_map.
      |  ^~~~~
make[3]: *** [scripts/Makefile.host:102: scripts/selinux/mdp/mdp] Error 1
In file included from scripts/selinux/genheaders/genheaders.c:19:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
  245 | #error New address family defined, please update secclass_map.
      |  ^~~~~
make[2]: *** [scripts/Makefile.build:573: scripts/selinux/mdp] Error 2
make[2]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.host:102: scripts/selinux/genheaders/genheaders] Error 1
make[2]: *** [scripts/Makefile.build:573: scripts/selinux/genheaders] Error 2
make[1]: *** [scripts/Makefile.build:573: scripts/selinux] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:562: scripts] Error 2

Looks like the problem is a slightly newer version of GLibc?

[plbossart]

atm I am running Windows on my laptop, is there any way to load this kernel with USB drive? Maybe compile kernel on WSL and then move it to bootable USB?

I don't have a Windows device so can't help with WSL.

It's possible to take an existing USB drive with e.g. Ubuntu and add a different kernel. I did it a couple of years ago with the help of @linuxium, see https://github.com/plbossart/UbuntuLiveUSB. No idea if this still works or not. You might have more luck with Cubic.

[playXE]

I'll probably buy a larger SSD and will install Linux near Windows because it seems to be quite hard to build linux kernel in WSL...