Enhancements to prepare supporting machine driver probing via device tree #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
juimonen,
keyonjie,
lgirdwood,
lyakh,
plbossart and
ranj063
as code owners
dbaluta
changed the title
plbossart
requested changes
Nov 7, 2019
Member
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
no objections on the idea, but the work is not complete, see below
Collaborator
Author
Thanks, for review. Yes, the work is not complete. I started this early in order to better sync with @ranj063 |
dbaluta
force-pushed
the
sof-dev
branch
2 times, most recently
from
0d497a0 to
4d0d507
Compare
Collaborator
Author
|
@ranj063 can you please take the first 2 patches in this series and rebase your PR on it?
|
Collaborator
Collaborator
Author
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SOF probes machine drivers by creating a platform device
and passing the machine description as private data.
This is driven by the ACPI restrictions. Ideally, ACPI tables
should contain the description for the machine driver. This is
not possible becuase ACPI tables are frozen and used on multiple
OS-es (e.g Windows).
In the case, of Device Tree we don't have this restrictions, so we
choose to probe the machine drivers by creating a DT node as is
the standard ALSA way.
This patch makes the probing of machine drivers from SOF core optional
allowing for arm platforms to decouple the SOF core from machine
driver probing.
@ranj063 I will push my work here. For now SOF core and machine drivers probing is tightly coupled.
Even for nocodec machine driver. It needs to know a lot of things from core: sof_pdata, desc and ops. Ideally, nocodec machine driver should only need the private data provided by device registration. (e.g the snd_soc_acpi_mach struct).
Will update this PR once I figure out more.