soundwire: cadence: fix pop noise issue when start playback #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver should clear FIFO in PDI, or the sample data in FIFO will generate pop noise when stream is started. The soft reset bit will clear all the FIFO to zero and is self-cleared after that. Signed-off-by: randerwang <rander.wang@linux.intel.com>
plbossart
approved these changes
Mar 11, 2020
Member
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Nice work @RanderWang !
This will happen for .hw_params and .prepare and so will also be applied for pause_release.
This was referenced Mar 16, 2020
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver should clear FIFO in PDI, or the sample data in FIFO
will generate pop noise when stream is started. The soft reset
bit will clear all the FIFO to zero and is self-cleared after
that.
Signed-off-by: randerwang rander.wang@linux.intel.com