Skip to content

Conversation

@xiulipan
Copy link

Share how many injection probe DMAs and how many probe points
driver can request from FW.
injection_dmas_max 0 means injection is not supported
probe_points_max 0 means whole probes subsystem in FW is not enabled
and not compiled in.

ABI version change to 3.14.0

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

Share how many injection probe DMAs and how many probe points
driver can request from FW.
injection_dmas_max 0 means injection is not supported
probe_points_max 0 means whole probes subsystem in FW is not enabled
and not compiled in.

ABI version change to 3.14.0

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@mengdonglin mengdonglin added the ABI involves ABI changes, need extra attention label Mar 30, 2020
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches ABI classifier and code alreary reviewed in the combined PR, so all good!

@kv2019i kv2019i requested review from lgirdwood and plbossart March 30, 2020 08:31
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, provided there is a plan for how to merge multiple PRs, changing the ABI version in incompatible ways.

@xiulipan
Copy link
Author

@@lgirdwood Ping here from thesofproject/sof#2522

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@lgirdwood
Copy link
Member

CI Jenkins known issues, checkpatch complaining about types u32 vs uint32_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants