-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC:SOF: Add src_hash to sof_ipc_fw_version structure
#2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ktrzcinx when you say 'value is used by sof-logger', did you mean that the value would be exposed in a debugfs value read by sof-logger? |
|
@plbossart |
This field will be used to compare ldc file with loaded fw version, to assert validity of trace logs. Value used in sof-logger. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
fw_hash to sof_ipc_fw_version structuresrc_hash to sof_ipc_fw_version structure
07c1965 to
4044683
Compare
|
FW part has been merged already, so this PR also should keep going. |
|
SOFCI TEST |
|
ping @kv2019i @ranj063 @plbossart |
|
@ktrzcinx I need more coffee but do we actually need this from the firmware, can't we get it from the extended manifest? |
|
@plbossart actually not, because only fw_ready message is accessible from sof-logger point of view. Logger is default reader of this information, here it's only added to keep data structures aligned. |
ok, thanks for the clarification |
|
@kv2019i can you take a look (ABI, etc)? Thanks! |
|
@plbossart Ack, I'm having some doubts on this -- kernel doesn't use this field, so why add it to the header. But given we don't annotate the changes to FW headers (I have an AR to fix that), keeping them in sync in other ways is problematic as well. Oh well, let's put this in. |
This field will be used to compare ldc file with loaded fw version,
to assert validity of trace logs. Value used in sof-logger.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com
Related with thesofproject/sof#3195