Skip to content

Conversation

@ktrzcinx
Copy link
Member

This field will be used to compare ldc file with loaded fw version,
to assert validity of trace logs. Value used in sof-logger.

Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com

Related with thesofproject/sof#3195

@ktrzcinx ktrzcinx added the ABI involves ABI changes, need extra attention label Jul 17, 2020
@plbossart
Copy link
Member

@ktrzcinx when you say 'value is used by sof-logger', did you mean that the value would be exposed in a debugfs value read by sof-logger?

@ktrzcinx
Copy link
Member Author

@plbossart sof_ipc_fw_version is part of fw_ready message, already saved in debugfs and already used by sof-logger for compatibility check

This field will be used to compare ldc file with loaded fw version,
to assert validity of trace logs. Value used in sof-logger.

Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
@ktrzcinx ktrzcinx changed the title [RFC] ASoC:SOF: Add fw_hash to sof_ipc_fw_version structure ASoC:SOF: Add src_hash to sof_ipc_fw_version structure Jul 29, 2020
@ktrzcinx
Copy link
Member Author

FW part has been merged already, so this PR also should keep going.

@ktrzcinx
Copy link
Member Author

SOFCI TEST

@ktrzcinx
Copy link
Member Author

ktrzcinx commented Sep 2, 2020

ping @kv2019i @ranj063 @plbossart

@plbossart
Copy link
Member

@ktrzcinx I need more coffee but do we actually need this from the firmware, can't we get it from the extended manifest?

@ktrzcinx
Copy link
Member Author

ktrzcinx commented Sep 2, 2020

@plbossart actually not, because only fw_ready message is accessible from sof-logger point of view. Logger is default reader of this information, here it's only added to keep data structures aligned.

@plbossart
Copy link
Member

@plbossart actually not, because only fw_ready message is accessible from sof-logger point of view. Logger is default reader of this information, here it's only added to keep data structures aligned.

ok, thanks for the clarification

@plbossart plbossart requested a review from kv2019i September 2, 2020 15:35
@plbossart
Copy link
Member

plbossart commented Sep 2, 2020

@kv2019i can you take a look (ABI, etc)? Thanks!

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 3, 2020

@plbossart Ack, I'm having some doubts on this -- kernel doesn't use this field, so why add it to the header. But given we don't annotate the changes to FW headers (I have an AR to fix that), keeping them in sync in other ways is problematic as well. Oh well, let's put this in.

@kv2019i kv2019i merged commit 7901bab into thesofproject:topic/sof-dev Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants