travis.yml: add i386 compilation #2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Travis CI target so that we can catch 32/64 bits earlier. Currently these errors are flagged after merging by the kbuild bot, we can do better. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
ranj063
as code owners
marc-hb
approved these changes
Aug 28, 2020
| - make modules_prepare | ||
| - make -j`getconf _NPROCESSORS_ONLN` sound/ | ||
| - make -j`getconf _NPROCESSORS_ONLN` drivers/soundwire/ | ||
| - make -j`getconf _NPROCESSORS_ONLN` |
Collaborator
There was a problem hiding this comment.
Nit1: cmd is basically deprecated, prefer $( ) https://github.com/koalaman/shellcheck/wiki/SC2006
Nit2: nproc seems more popular than getconf _NPROCESSORS_ONLN. It's shorter and can apparently return a lower value in some cases.
Member
Author
There was a problem hiding this comment.
@marc-hb do you mind sending a follow-up patch? I don't speak bash fluently.
Collaborator
There was a problem hiding this comment.
do you mind sending a follow-up patch?
PR #2405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Travis CI target so that we can catch 32/64 bits
earlier. Currently these errors are flagged after merging by the
kbuild bot, we can do better.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com