Skip to content

Conversation

@xiulipan
Copy link

@xiulipan xiulipan commented Aug 28, 2020

Ubuntu 18.04 bionic is history
Remove the ppa for gcc tools as the default gcc version now
is GCC 9.3

Update the clang build with latest update from LLVM with only CC=clang
https://www.kernel.org/doc/html/latest/kbuild/llvm.html

fix #2398

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

Ubuntu 18.04 bionic is history
Remove the ppa for gcc tools as the default gcc version now
is GCC 9.3

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan xiulipan changed the title .travis.yaml: bump image to Ubuntu 20.04 focal update Travis scripts Aug 28, 2020
From Linux 5.8, we can use CC=clang for clang build.
Remove the lkp scripts usage.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good but clang build seems to fail:

Compiler lacks asm-goto support.

make: *** [arch/x86/Makefile:284: checkbin] Error 1

The command "make CC=clang ARCH=x86_64" exited with 2.

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2020

Ubuntu 18.04 bionic is history

It's not that old, do we really want to stop supporting it, even when it seems to still be compiling everything fine? I think @libinyang has been spending a lot of effort backporting ALSA packages to 18.04

@plbossart
Copy link
Member

One step at a time please

A) fix PPA issue (send PR #2406)
B) fix makefile options (PR #2405)
C) fix Clang (errors + you are missing the parallel compilation added in B - was part of make.cross)
D) change to focal. I think we need to ditch 18.04 for development, no one should be using it in the SOF teams.

@marc-hb marc-hb requested a review from cujomalainey August 28, 2020 19:55
@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2020

D) change to focal. I think we need to ditch 18.04 for development,

Not sure what you mean by "for development", what else is there besides "development"?

So was @libinyang 's 18.04 work in #2211 just a waste of time?

BTW sof-docs still refer to 16.04 and to 18.04 but not to 20.04 yet
https://thesofproject.github.io/latest/getting_started/build-guide/build-from-scratch.html#step-1-set-up-build-environment

There's evidence of some developer(s) still using 16.04: thesofproject/sof#3166 (comment) (cc: @mrajwa , @jajanusz )

which is surprising considering the recent ALSA dependencies for UUID thesofproject/sof#2919

no one should be using it in the SOF teams.

Most (but not all) developers tend to use the latest and greatest, which is why it is useful to keep CI on the oldest and supported versions.

@plbossart
Copy link
Member

Most (but not all) developers tend to use the latest and greatest, which is why it is useful to keep CI on the oldest and supported versions.

It took me 3 months to ask that all CI target devices use 20.04, I don't want a repeat here.
Everyone uses 20.04, period. SOF CI also uses 20.04. If there is a compilation bug with another setup, kbuild will tell us.

And yes I don't care about alsa-lib for 18.04, this is completely useless. The ask was on 20.04 so that we can test on CI/test devices.

@libinyang
Copy link

So was @libinyang 's 18.04 work in #2211 just a waste of time?

@marc-hb I didn't work on 18.04 now. Our CI has already moved to 20.04. Please refer the patches for alsa-lib and pulseaudio in gitlab and the jenkins job of build_userspace_package. They are for 20.04.

@xiulipan
Copy link
Author

@kv2019i @plbossart I will close this PR as I see most task is already done.

@xiulipan xiulipan closed this Aug 31, 2020
marc-hb added a commit to marc-hb/sof that referenced this pull request Sep 19, 2020
The current default Travis default is 16.04 which is obsolete.

From thesofproject/linux#2402

> Everyone uses 20.04, period. SOF CI also uses 20.04.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb added a commit to marc-hb/sof that referenced this pull request Sep 20, 2020
The current default Travis default is 16.04 which is obsolete.

From thesofproject/linux#2402

> Everyone uses 20.04, period. SOF CI also uses 20.04.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood pushed a commit to thesofproject/sof that referenced this pull request Sep 21, 2020
The current default Travis default is 16.04 which is obsolete.

From thesofproject/linux#2402

> Everyone uses 20.04, period. SOF CI also uses 20.04.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood pushed a commit to thesofproject/sof that referenced this pull request Sep 23, 2020
The current default Travis default is 16.04 which is obsolete.

From thesofproject/linux#2402

> Everyone uses 20.04, period. SOF CI also uses 20.04.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRAVIS CI] fails due to ppa configuration issues

5 participants