ASoC: intel: hdac_hdmi: fix use _write function for SET_POWER_STATE verb #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
reviewed
Nov 6, 2018
| */ | ||
| snd_hdac_codec_read(hdev, hdev->afg, 0, AC_VERB_SET_POWER_STATE, | ||
| AC_PWRST_D3); | ||
| snd_hdac_codec_write(hdev, hdev->afg, 0, AC_VERB_SET_POWER_STATE, |
Collaborator
Collaborator
Author
|
Thanks @ranj063 Now I understand why it uses snd_hdac_codec_read instead of snd_hdac_codec_write. :) |
Currently we use snd_hdac_codec_read to set AC_VERB_SET_POWER_STATE verb. Replace it with snd_hdac_codec_write. Signed-off-by: Bard liao <bard.liao@intel.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use snd_hdac_codec_read to set AC_VERB_SET_POWER_STATE
verb. Replace it with snd_hdac_codec_write.
Signed-off-by: Bard liao bard.liao@intel.com