travis: separate check patch and age of git base #2547
Conversation
.travis.yml
Outdated
There was a problem hiding this comment.
out of curiosity, what are those '*unshallow_for_merge_base" and "&unshallow_for_merge_base"?
There was a problem hiding this comment.
They're YAML anchors = how to avoid copy/paste/diverge.
|
@marc-hb Shouldn't the checkpatch run https://travis-ci.org/github/thesofproject/linux/builds/740309390 succeed here (i.e. detect git clone is too shallow and run unshallow on the repo before checkpatch)...? |
Yes it should. But it doesn't. @ranj063 spotted a similar issue in https://travis-ci.org/github/thesofproject/linux/jobs/739977895. I reproduced this locally at last and root-caused it to the crazy (buggy?) way |
As requested in fix for checkpatch issue PR thesofproject#2543 which will be rebased on top of this. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
ranj063
as code owners
|
Rebased and added https://travis-ci.org/github/thesofproject/linux/builds/741026106 is looking good. Even though the #2543 "fix" is uncertain and needs to be discussed and revisited I think this PR is good because it has no real functional change, it's just removing a confusing "optimization" and making the Travis output simpler and clearer. PS: ICL_RVP_HDA's failure to boot in https://sof-ci.01.org/linuxpr/PR2547/build4824/devicetest can obviously not be related to this. |
Finally done, see graphical explanation of the issue in freshly filed |
|
Not sure where this is going and if Travis is still relevant. closing. |
|
Summary at #2543 (comment) |
3 participants
As requested in fix for checkpatch issue PR #2543 which will be rebased
on top of this.
Signed-off-by: Marc Herbert marc.herbert@intel.com