[RFC] soundwire: cadence_master: wait for HW reset before clock stop #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
jack-cy-yu,
oder-chiou,
ryans-lee and
shumingfan
as code owners
Collaborator
Author
|
@plbossart I am not sure if it is enough. There may be a better place to check the CDNS_MCP_CONTROL_HW_RST bit. |
We set CDNS_MCP_CONTROL_HW_RST and do config update in sdw_cdns_exit_reset. The reset state will be pending for clocks period, and The CDNS_MCP_ CONTROL_HW_RST is self cleared. We have to make sure the bit has been cleared before doing another config update. Otherwise, we will do HW reset accidentally when we call cdns_config_update() in sdw_cdns_clock_stop(). Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
changed the title
bardliao
force-pushed
the
check-cdns-mcp-hw-rst
branch
from
5ad58b7 to
60f631c
Compare
Collaborator
Author
|
It doesn't work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set CDNS_MCP_CONTROL_HW_RST and do config update in sdw_cdns_exit_reset.
The reset state will be pending for clocks period, and The CDNS_MCP_
CONTROL_HW_RST is self cleared. We have to make sure the bit has been
cleared before doing another config update. Otherwise, we will do HW reset
accidentally when we call cdns_config_update() in sdw_cdns_clock_stop().
Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com