fixup! ASoC: SOF: handle paused streams during system suspend #3126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
plbossart
as code owners
Tearing down pipelines is only supported with firmware ABI 3.19 or greater. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/pause_resume_v2
branch
from
087a8e5 to
763d7aa
Compare
plbossart
approved these changes
Aug 30, 2021
Member
|
I tested this with firmware 1.8, without this patch either the device does not wake at all, or I get his error on resume |
Member
|
One suspend-resume timeout in https://sof-ci.01.org/linuxpr/PR3126/build6253/devicetest/?model=TGLU_RVP_SDW&testcase=check-suspend-resume-with-playback, let's redo the tests. @bardliao can you take a look? |
Member
|
SOFCI TEST |
Collaborator
|
Thanks @ranj063 This fixes the issue I saw in #3098 (comment) |
bardliao
approved these changes
Aug 31, 2021
Collaborator
bardliao
left a comment
bardliao
left a comment
There was a problem hiding this comment.
LGTM and no issue found on pr-device-test.
paulstelian97
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tearing down pipelines is only supported with firmware
ABI 3.19 or greater.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com