fixup! ASoC: SOF: Introduce struct snd_sof_pipeline

[ranj063]

Clear the complete flag for pipelines when the scheduler widget is freed.

Fixes #3983

[keqiaozhang]

Verified that this PR can fix #3983.

[plbossart]

I don't know what to make of the results @ranj063 @keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

[ujfalusi]

I don't know what to make of the results @ranj063 @keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

I think what happened is that multiple-pipeline-playback.sh failed - firmware crash - (if it is because of this PR or not is a question) since we prevent powering down the DSP to preserve the DSP state. Consecutive tests fail since the DSP is kept powered in crashed state. With IPC4/Zephyr we don't have panic interrupt/message so we can not force a DSP power cycle.

Let me check it locally, it should be easy to hit.

[ujfalusi]

Can a pipeline belong to different paths?

[ranj063]

@ujfalusi yes it can and the scheduler widget will be freed only when the last of all the users lets it go

[ujfalusi]

Let me check it locally, it should be easy to hit.

No crash so far after 46 iteration.

[ranj063]

I don't know what to make of the results @ranj063 @keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

@plbossart IPC4 failures are due toe the chaind DAM SOF PR which shouldnt have been merged. There's a revert for that as well

[ranj063]

I don't know what to make of the results @ranj063 @keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

I think what happened is that multiple-pipeline-playback.sh failed - firmware crash - (if it is because of this PR or not is a question) since we prevent powering down the DSP to preserve the DSP state. Consecutive tests fail since the DSP is kept powered in crashed state. With IPC4/Zephyr we don't have panic interrupt/message so we can not force a DSP power cycle.

Let me check it locally, it should be easy to hit.

it is because of the SOF PR for chained DMA that was merged a bit too early

[plbossart]

@ujfalusi any objections here? this needs to go in before 2pm PDT to fix daily tests