!fixup ASoC: SOF: add delay function support for ipc4 driver #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ranj063,
ujfalusi and
yaochunhung
as code owners
ranj063
previously approved these changes
Nov 30, 2022
aiChaoSONG
previously approved these changes
Nov 30, 2022
bardliao
previously approved these changes
Nov 30, 2022
Merged
ujfalusi
reviewed
Nov 30, 2022
| if (node_id == SOF_IPC4_INVALID_NODE_ID) | ||
| node_index = SOF_IPC4_NODE_INDEX(host_copier->data.gtw_cfg.node_id); | ||
| if (host_copier->data.gtw_cfg.node_id == SOF_IPC4_INVALID_NODE_ID) | ||
| return -EINVAL; |
Collaborator
There was a problem hiding this comment.
it would be better to swap these to be easier to follow:
if (host_copier->data.gtw_cfg.node_id == SOF_IPC4_INVALID_NODE_ID)
return -EINVAL;
node_index = SOF_IPC4_NODE_INDEX(host_copier->data.gtw_cfg.node_id);
Author
There was a problem hiding this comment.
@ujfalusi I did it first in this way, but I found it resulted to great change in diff, so do it this way. Let's do it as your suggestion
It should use full part of node_id to compare to SOF_IPC4_INVALID_NODE_ID, Also rename local variable node_id to node_index to make it more clear Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
dismissed stale reviews from jsarha, bardliao, aiChaoSONG, and ranj063
via
00251d2
RanderWang
force-pushed
the
ipc4_fixup_delay
branch
from
be83301 to
00251d2
Compare
ujfalusi
approved these changes
Nov 30, 2022
| if (node_id == SOF_IPC4_INVALID_NODE_ID) | ||
| node_index = SOF_IPC4_NODE_INDEX(host_copier->data.gtw_cfg.node_id); | ||
| if (host_copier->data.gtw_cfg.node_id == SOF_IPC4_INVALID_NODE_ID) | ||
| return -EINVAL; |
bardliao
approved these changes
Nov 30, 2022
jsarha
approved these changes
Nov 30, 2022
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Even better than before. Please merge soon!
plbossart
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should use full part of node_id to compare to SOF_IPC4_INVALID_NODE_ID, Also rename local variable node_id to node_index to make it more clear
fix #4048