ASoC: SOF: Use generic IPC type identifiers #4301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
RanderWang,
ajitkupandey,
bardliao,
bhiregoudar,
dbaluta,
juimonen,
kuanhsuncheng,
kv2019i,
lgirdwood,
libinyang,
lyakh,
plbossart,
ranj063,
sunilkumardommati,
vijendarmukunda and
yaochunhung
as code owners
paulstelian97
previously approved these changes
Apr 13, 2023
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Barring some typos in commit descriptions here and there (e.g. in the "Drop unused IPC type defines" one you added an unintentional space as in "...t he generic names...") this is a welcome change.
Collaborator
Author
@paulstelian97, thanks, I will fix the typos in v2! |
vijendarmukunda
previously approved these changes
Apr 13, 2023
RanderWang
previously approved these changes
Apr 13, 2023
dbaluta
previously approved these changes
Apr 13, 2023
ujfalusi
dismissed stale reviews from dbaluta, RanderWang, vijendarmukunda, and paulstelian97
via
017c1d1
ujfalusi
force-pushed
the
peter/sof/pr/generic_ipc_type_naming_01
branch
from
7ae4318 to
017c1d1
Compare
Collaborator
Author
|
Changes since v1:
|
paulstelian97
previously approved these changes
Apr 13, 2023
ujfalusi
force-pushed
the
peter/sof/pr/generic_ipc_type_naming_01
branch
from
017c1d1 to
d5bc31b
Compare
Collaborator
Author
|
Thanks you all for the approvals! I would wait a bit with merging this until other, mor important PRs are merged where the naming change can cause dependency for upstreaming. I will also have a followup PR to rework the firmware, topology path and firmware name presentation, I will create a draft with the current implementation, which is likely not going to be the right way, but I need to test how it is stretching. |
RanderWang
previously approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Closed
Change the enum names for the IPC types to be more descriptive and drop tying the IPC4 to Intel SoCs. Add defines to avoid build breakage while the related code is modified to use the new enum names. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Clarify the description of the ipc_type module parameter and drop the Intel CAVS in favor of IPC4. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Drop the Intel from the IPC type Kconfig option Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
dismissed stale reviews from RanderWang, iuliana-prodan, ranj063, and plbossart
via
6ea5832
Use the new SOF_IPC_TYPE_3, SOF_IPC_TYPE_4 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/sof/pr/generic_ipc_type_naming_01
branch
from
d5bc31b to
6ea5832
Compare
Collaborator
Author
|
Changes since v3:
|
Use the new SOF_IPC_TYPE_3 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Use the new SOF_IPC_TYPE_3 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Use the new SOF_IPC_TYPE_3, SOF_IPC_TYPE_4 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Use the new SOF_IPC_TYPE_4 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Use the new SOF_IPC_TYPE_3 in core code. No functional changes, just renaming. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The SOF stack now uses the generic names for the IPC type, the defines can be dropped. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/sof/pr/generic_ipc_type_naming_01
branch
from
6ea5832 to
3c2915e
Compare
Collaborator
Author
|
Changes since v4:
|
dbaluta
approved these changes
Aug 9, 2023
ranj063
approved these changes
Aug 10, 2023
plbossart
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
rename the IPC type defines to be more generic and intuitive:
SOF_IPC -> SOF_IPC_TYPE_3
SOF_INTEL_IPC4 -> SOF_IPC_TYPE_4
No functional change, just renaming all around.