ASoC: SOF: mediatek: add mt8188 audio support #4319
Conversation
wenliangwu
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ranj063,
ujfalusi and
yaochunhung
as code owners
There was a problem hiding this comment.
is the only different the DAIs? If yes, you may want to have a common part that's overridden with the delta (as done for Intel to avoid copy/paste of mostly the same structure).
There was a problem hiding this comment.
Thanks for your suggestion, I will make use of ops_init callback as done for intel.
Add mt8188 dai driver and specify of_machine to support mt8188 audio. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Add mt8188 and mt8186 .dbg_dump callback to print some information when DSP panic occurs. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
|
@plbossart https://patchwork.kernel.org/project/alsa-devel/patch/20230515052540.9037-2-trevor.wu@mediatek.com/ |
|
@wenliangwu thanks for asking. Usually what we do is submit a patch with the same commit title but a 'fixup!' prefix, that will be merged to topic/sof-dev, then we squash this patch with the initial one and send the squashed patch upstream. If you send your changes directly upstream it will generate conflicts for us, it's relatively painful so please try to use fixups first. |
|
Got it. Thanks for your detailed explanation. I will prepare a fixup commit first. |
4 participants
Some necessary initialization like of_machine and dai driver for audio support are included. On the other hand, add dbg_dump callback for DSP panic information.