Skip to content

Conversation

@plbossart
Copy link
Member

…figuration

The new entry was added before the SDCA AOIC, which causes MTL SDW AOIC to select 2 devices only - which as a result causes a fail during the topology load.

Closes: #4906

…figuration

The new entry was added before the SDCA AOIC, which causes MTL SDW
AOIC to select 2 devices only - which as a result causes a fail during
the topology load.

Closes: thesofproject#4906
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
Copy link
Member Author

ok, with this PR I get the following tests passing with run-all-tests

PASS: tplg-binary; pcm_list; playback-d100l1r1; capture-d100l1r1; playback-d1l100r1; capture_d1l100r1; playback_d1l1r50; capture_d1l1r50; speaker; pause-resume-playback; pause-resume-capture; signal-stop-start-playback; signal-stop-start-capture; multiple-pipeline-playback; multiple-pipeline-capture; multiple-pause-resume; kmod-load-unload; kmod-load-unload-after-playback; suspend-resume; suspend-resume-with-playback; suspend-resume-with-capture;

@plbossart
Copy link
Member Author

@plbossart plbossart merged commit bf16d88 into thesofproject:topic/sof-dev Apr 6, 2024
@bardliao
Copy link
Collaborator

bardliao commented Apr 8, 2024

Hmm, this let me think if matching subset of mach->link_mask still a good idea? d43dc16
I guess we will make this kinds of mistake time to time. Maybe we should clean up all acpi mach tables to group items with the same link_mask? So that we can add new items to the right position with the same link_mask grouped.

@plbossart
Copy link
Member Author

It's not a bad idea @bardliao, the current direction requires use to be really careful when introducing a new entry. If we added a new entry based on the link_mask, it would reduce the potential for interference.
At the same time, it would make the versions with two amps or one amp less obvious but they are different devices anyways.

Do you want to take a stab at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MTL SDW AOIC fails to load topology

2 participants