Skip to content

AMD SOF based generic SoundWire machine driver #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plbossart merged 31 commits into from
Jul 5, 2024
Merged

AMD SOF based generic SoundWire machine driver #5068

plbossart merged 31 commits into from
Jul 5, 2024

Conversation

@vijendarmukunda
Copy link

@vijendarmukunda vijendarmukunda commented Jun 18, 2024

This patch series is rebase version of PR#5034

plbossart
plbossart reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me @vijendarmukunda

I only have minor comments, time for others to comment as well. @bardliao @charleskeepax on your mark, set, go!

plbossart
plbossart requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last patch needs a bit more work IMHO, still too much duplication of complicated code that we don't want to fork.

The rest looks ok, thanks!

@plbossart
Copy link
Member

plbossart commented Jun 25, 2024

SOFCI TEST

bardliao
bardliao reviewed Jun 25, 2024
View reviewed changes
@vijendarmukunda
Copy link
Author

vijendarmukunda commented Jun 25, 2024 •
edited
Loading

The last patch needs a bit more work IMHO, still too much duplication of complicated code that we don't want to fork.

The rest looks ok, thanks!

Agreed. We are going to refactor the code . We need to add support for newer ACP variants. We are going to add support for legacy (NO DSP) machine driver support where we are going to refactor existing code.
We would like to implement as an incremental patch series.

@vijendarmukunda
ASoC: intel: rename codec_info and dai_info structures names
3a661c4 
To make it generic, rename structure 'sof_sdw_codec_info' as
'asoc_sdw_codec_info' and 'sof_sdw_dai_info' as 'asoc_sdw_dai_info'.
These structures will be moved to common header file so that it can
be used by other platform machine driver.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: rename soundwire common header macros
7368b98 
Rename sof quirk macros, dai type and dai link macros with "SOC_SDW" tag.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: rename soundwire machine driver soc ops
a1e2861 
Rename Soundwire generic machine driver soc ops with tag "asoc".

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: rename soundwire codec helper functions
a90e6f9 
Rename SoundWire codec helper functions with "asoc_sdw" tag.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: rename maxim codec macros
ae5e49e 
Rename maxim codec part id macros.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: rename ignore_pch_dmic variable name
954cc8b 
Rename 'ignore_pch_dmic' variable name as 'ignore_internal_dmic'.
This variable will be moved to common header file and will be used by other
platform machine driver code.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw-utils: move soundwire machine driver soc ops
4fbc325 
Move Intel SoundWire generic machine driver soc ops to common place
so that it can be used by other platform machine driver.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: move soundwire machine driver common structures
d15fc43 
Move intel generic SoundWire machine driver common structures to
soc_sdw_utils.h file. These structures will be used in other platform
SoundWire machine driver code.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move soundwire machine driver helper functions
f0a24d6 
Move below Intel SoundWire machine driver helper functions to
soc_sdw_utils.c file so that it can be used by other platform machine
driver.
- asoc_sdw_is_unique_device()
- asoc_sdw_get_codec_name()

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move dmic codec helper function
565442e 
Move generic dmic codec helper function implementation to
sdw_utils folder so that this function can be used by other platform
machine drivers.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move rtk dmic helper functions
5b8cde7 
Move rtk SoundWire dmic helper functions implementation to sdw_utils
folder to make it generic.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt712 sdca helper functions
f07f5a2 
Move RT712 SDCA codec helper file to sdw_utils folder so that these
helper functions can be used by other platform machine drivers.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt722 sdca helper functions
7ae6655 
Move RT722 SDCA codec helper file to sdw_utils folder to make it generic.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel: split soundwire machine driver private data
9d227b8 
Split intel generic SoundWire machine driver private data into two
structures. One structure is generic one which can be used by other
platform machine driver and the other one is intel specific one.
Move generic machine driver private data to soc_sdw_utils.h.
Define a void pointer in generic machine driver private data structure
and assign the vendor specific structure in mc_probe() call.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt5682 codec helper function
65db629 
Move rt5682 sdw codec helper function to common place holder to make it
generic.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: rename soundwire common header macros
a5a0469 
BugLink: https://bugs.launchpad.net/bugs/2080190

Rename sof quirk macros, dai type and dai link macros with "SOC_SDW" tag.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-3-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 408a454 linux-next)
Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: rename soundwire machine driver soc ops
b80decb 
BugLink: https://bugs.launchpad.net/bugs/2089273

Rename Soundwire generic machine driver soc ops with tag "asoc".

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-4-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 96990cf linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: rename soundwire codec helper functions
21894e6 
BugLink: https://bugs.launchpad.net/bugs/2089273

Rename SoundWire codec helper functions with "asoc_sdw" tag.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-5-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit bd5838c linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: rename maxim codec macros
6d27b47 
BugLink: https://bugs.launchpad.net/bugs/2089273

Rename maxim codec part id macros.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-6-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit a2b5ec0 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: rename ignore_pch_dmic variable name
350dd96 
BugLink: https://bugs.launchpad.net/bugs/2089273

Rename 'ignore_pch_dmic' variable name as 'ignore_internal_dmic'.
This variable will be moved to common header file and will be used by other
platform machine driver code.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-7-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit b1f7cbf linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw-utils: move soundwire machine driver soc ops
fc81300 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move Intel SoundWire generic machine driver soc ops to common place
so that it can be used by other platform machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-8-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit d39388e linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: move soundwire machine driver common structures
4699f56 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move intel generic SoundWire machine driver common structures to
soc_sdw_utils.h file. These structures will be used in other platform
SoundWire machine driver code.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-9-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 7361913 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move soundwire machine driver helper functions
40f610f 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move below Intel SoundWire machine driver helper functions to
soc_sdw_utils.c file so that it can be used by other platform machine
driver.
- asoc_sdw_is_unique_device()
- asoc_sdw_get_codec_name()

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-10-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 941d693 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move dmic codec helper function
1d3db9b 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move generic dmic codec helper function implementation to
sdw_utils folder so that this function can be used by other platform
machine drivers.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-11-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 4776d0c linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rtk dmic helper functions
1c6cea0 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move rtk SoundWire dmic helper functions implementation to sdw_utils
folder to make it generic.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-12-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit a9831fd linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rt712 sdca helper functions
8a239d4 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move RT712 SDCA codec helper file to sdw_utils folder so that these
helper functions can be used by other platform machine drivers.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-13-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 09c60bc linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rt722 sdca helper functions
779ba47 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move RT722 SDCA codec helper file to sdw_utils folder to make it generic.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-14-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 89b3456 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel: split soundwire machine driver private data
65e2b7b 
BugLink: https://bugs.launchpad.net/bugs/2089273

Split intel generic SoundWire machine driver private data into two
structures. One structure is generic one which can be used by other
platform machine driver and the other one is intel specific one.
Move generic machine driver private data to soc_sdw_utils.h.
Define a void pointer in generic machine driver private data structure
and assign the vendor specific structure in mc_probe() call.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-15-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 4f54856 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rt5682 codec helper function
53be7ba 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move rt5682 sdw codec helper function to common place holder to make it
generic.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-16-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 139e177 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rtk jack common helper functions
3eac387 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move RTK codec jack common helper functions to common place holder
(sdw_utils folder) to make it generic so that it will be used by
other platform machine driver code.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-17-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit da5b183 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rt700 and rt711 codec helper functions
7d69a96 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move RT700 and RT711 Soundwire codec helper functions to common
place holder so that it can be used by other platform machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-18-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8e84fd2 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move rtk amp codec helper functions
9d8b720 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move RTK amp codec helper functions related implementation to common
place holder to make it generic so that these helper functions will be
used by other platform machine driver modules.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-19-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit ccc96ae linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move cirrus soundwire codec helper functions
892ea16 
BugLink: https://bugs.launchpad.net/bugs/2089273

To make it generic, move Cirrus Soundwire codec helper functions to
common place holder so that it can be used by other platform machine
driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-20-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 5fa4662 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move maxim codec helper functions
ac6a451 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move maxim codec helper functions to common place holder so that
it can be used by other platform machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801091446.10457-21-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 051b7cb linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move dai id common macros
af41b8b 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move dai id common macros from intel SoundWire generic driver to
soc_sdw_utils.h file so that it can be used by other platform machine
driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-1-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8f87e29 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move soundwire dai type macros
7fa3fdd 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move SoundWire dai type macros to common header file(soc_sdw_util.h).
So that these macros will be used by other platform machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-2-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 6e7af1f linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move soundwire codec_info_list structure
fcabb79 
BugLink: https://bugs.launchpad.net/bugs/2089273

SoundWire 'codec_info_list' structure is not a platform specific one.
Move codec_info_list structure to common file soc_sdw_utils.c.
Move codec helper functions which uses codec_info_list structure to common
place holder and rename the function by adding _sdw tag. This will allow
to use 'codec_info_list' structure and it's helper functions in other
platform machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-3-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit e377c94 linux-next)
[kyyc0426: Had to adjust the context due to conflict commit 0ecf2da]
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: move machine driver dai link helper functions
acfa813 
BugLink: https://bugs.launchpad.net/bugs/2089273

Move machine driver dai link helper functions to common place holder,
So that it can be used by other platform machine driver.
Rename these functions with "asoc_sdw" tag as a prefix.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-4-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 778dcb0 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: sdw_utils: refactor sof_sdw_card_late_probe function
f43108a 
BugLink: https://bugs.launchpad.net/bugs/2089273

Refactor sof_sdw_card_late_probe() function and derive a generic
function soc_sdw_card_late_probe() function which can be used by
SoundWire generic machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-5-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 5bd414c linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: intel/sdw_utils: refactor init_dai_link() and init_simple_dai_l…
e9be6db 
…ink()

BugLink: https://bugs.launchpad.net/bugs/2089273

To make it generic, refactor existing implementation for
init_dai_link() and init_simple_dai_link() as mentioned below.
- Move init_dai_link() and init_simple_dai_link() to common place holder
- Rename the functions with "asoc_sdw" as prefix.
- Pass the platform specific 'platform_component' structure and its size as
arguments for init_simple_dai_link() function and allocate one more
extra dlc for platform component.
- Pass the 'platform_component' and 'num_platforms' as arguments for
init_dai_link().

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-6-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 59f8b62 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: soc-acpi: add pci revision id field in mach params structure
ef80467 
BugLink: https://bugs.launchpad.net/bugs/2089273

Few IP's may have same PCI vendor id and device id and
different revision id. Add revision id field to the
'snd_soc_acpi_mach_params' so that using this field platform
specific implementation can be added in machine driver.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-7-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 0b8f009 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: amd: acp: add soundwire machines for acp6.3 based platform
78d1be6 
BugLink: https://bugs.launchpad.net/bugs/2089273

Add Soundwire machines for acp6.3 based platform.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-8-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 57677cc linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: SOF: amd: add alternate machines for acp6.3 based platform
5f856ea 
BugLink: https://bugs.launchpad.net/bugs/2089273

Add SoundWire machines as alternate machines for acp6.3 based platform.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-9-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 15049b6 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: SOF: amd: update mach params subsystem_rev variable
db65749 
BugLink: https://bugs.launchpad.net/bugs/2089273

Add pci_rev variable in acp sof driver private data structure and assign
this value to mach_params structure subsystem_rev variable.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-10-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit b7cdb4a linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
vicamo pushed a commit to canonical/hwe-packages-build-helpers that referenced this pull request Nov 7, 2025
@vijendarmukunda @kylee0215
ASoC: amd/sdw_utils: add sof based soundwire generic machine driver
c4e2492 
BugLink: https://bugs.launchpad.net/bugs/2089273

Add sof based Soundwire generic driver for amd platforms.
Currently support added for ACP6.3 based platforms.

Link: thesofproject/linux#5068
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240801111821.18076-11-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit cb8ea62 linux-next)
Signed-off-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>
Acked-by: Chia-Lin Kao (AceLan) <chia-lin.kao@canonical.com>
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charleskeepax charleskeepax charleskeepax left review comments

@plbossart plbossart plbossart approved these changes

@bardliao bardliao bardliao approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@ujfalusi ujfalusi Awaiting requested review from ujfalusi ujfalusi is a code owner

+1 more reviewer

@bhiregoudar bhiregoudar bhiregoudar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vijendarmukunda @plbossart @perexg @charleskeepax @bardliao @bhiregoudar