-
Notifications
You must be signed in to change notification settings - Fork 140
Add match entries for a bunch of coming cs42l43 laptop SKUs #5130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add match entries for a bunch of coming cs42l43 laptop SKUs #5130
Conversation
plbossart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good but don't we also need the machine driver quirks?
@plbossart I think quirks is needed only if cs42l43 speaker is used or cs42l43 works as bridge mode. |
|
Yeah some quirks will need to be added, but I am being a little more cautious with sending up the quirks as they depend on the SSID and as we found out with the last set sometimes those aren't as locked down as I thought. Where as these bus layouts are locked down pretty early. |
Add some new match table entries on Arrowlake for some coming cs42l43 laptops. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Add some new match table entries on Alderlake for some coming cs42l43 laptops. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Add some new match table entries on Lunarlake for some coming cs42l43 laptops. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
f379e8c to
212cee1
Compare
|
@charleskeepax @bardliao are all the topologies listed in this PR part of the SOF tree now? Confused about this PR thesofproject/sof#9355 which is still a draft .... |
This is a draft because it has not been tested on the actual device, yet. |
|
Most of these are missing actually topologies yet, do you generally prefer to merge the topologies before the match entries? I could probably put a patch together although I don't have hardware to test most of them. |
|
it's usually better to merge and send this stuff upstream due to the development process, the patches will not be in Linus' tree before end of the year. |
No description provided.