Skip to content

Conversation

@macchian
Copy link

@macchian macchian commented Dec 3, 2024

This patch adds support for the rt712_vb multi-function codec and rt1320 amplifier.
oth devices are connected via a single Soundwire link 3, sharing the sdw3-clock, sdw3-data[0] and sdw3-data[1] data lanes
respectively.

@macchian macchian changed the title Mac dev alc712 ASoC: Intel: soc-acpi-intel-ptl-match: Add rt712_vb and rt1320 support Dec 4, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a need for the '-1' suffix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a need for the '-1' suffix?
yes, we checked the substring at https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sdw_utils/soc_sdw_rt_amp.c#L205

@plbossart
Copy link
Member

superseded by #5315 @macchian @ujfalusi ?

@macchian
Copy link
Author

macchian commented Feb 12, 2025

superseded by #5315 @macchian @ujfalusi ?
It looks like a different soundwire link configuration.

@ranj063
Copy link
Collaborator

ranj063 commented Apr 1, 2025

@macchian is this PR still relevant?

@macchian
Copy link
Author

macchian commented Apr 2, 2025

yes, I will rebase the PR and submit for reviewing. The 712_l3_1320_l3 are both probed successfully.

@macchian macchian force-pushed the mac-dev-alc712 branch 2 times, most recently from 190388e to 7b46538 Compare April 7, 2025 08:28
macchian added 2 commits April 7, 2025 16:44
The variable name contains duplications;thus, remove the redundant strings.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
This patch adds support for the rt712_vb multi-function codec and
rt1320 amplifier. Both devices are connected via a single Soundwire link 3,
sharing the sdw3-clock, sdw3-data[0] and sdw3-data[1] data lanes
respectively.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@macchian macchian marked this pull request as ready for review April 8, 2025 03:19
@ranj063 ranj063 merged commit 2f94e6e into thesofproject:topic/sof-dev Apr 8, 2025
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants