Sof hda series for legacy hda mode enabling. #74

keyonjie · 2018-08-10T12:07:13Z

it's still quite drafted, but with it, legacy mode playback goes(with no sound).

Define a function sof_create_platform_device() to register the platform device "sof-audio". And SOF PCI, ACPI, SPI probe function will all use this function in their firmware request callback function. Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

plbossart

lots of good work that needs to be refined a bit.
I would really remove the Kconfig based tests and add variables that can be used when the DSP is not present.

plbossart · 2018-08-10T17:14:17Z

sound/soc/sof/core.c

or DSP is not enabled, you could test this on SKL!

OK, I will add checking of DSP's availability.

plbossart · 2018-08-10T17:15:13Z

sound/soc/sof/core.c

make this a variable that is enabled if IS_ENABLED(FORCE_LEGACY_HDA) || (DSP not enabled)

OK, will change it.

plbossart · 2018-08-10T17:15:46Z

sound/soc/sof/core.c

isn't the debug tied to DSP?

I need refine this part, and adding check to dsp availability also.

plbossart · 2018-08-10T17:16:32Z

sound/soc/sof/intel/Kconfig

too many double negations or typos?

it's typo here, should be "Say Y if you do want to use this mode."

plbossart · 2018-08-10T17:17:54Z

sound/soc/sof/intel/hda-pcm.c

add comment here on the difference between capture and playback.

OK, will do.

plbossart · 2018-08-10T17:23:20Z

sound/soc/sof/pcm.c

Ah so this one is very interesting. Why not rely on DPIB all the time? Is there a reason why we need to reason from the DSP?
It really looks like either the DSP provides the information, or the DMA does it through the pointer information. This should be a platform property, not hardcoded with a define.

that's true, the new update is that the DPIB works for DSP I2S also on my local platform, I will run more test and if no regression then we can switch to use DPIB for all mode(I still want to keep IPC position update as another choice though).

plbossart · 2018-08-10T17:24:05Z

sound/soc/sof/intel/hda-stream.c

again use a variable (or a field in the device structure).

you mean the same as above with adding dsp availability check?

plbossart · 2018-08-10T17:25:21Z

sound/soc/sof/intel/hda-stream.c

Ah very interesting. We had a discussion that there should be only one source for period elapsed, but here you are adding another one? Would this work in normal mode w/ the DSP enabled?

to use DPIB mode, we need add this and remove the IPC one. Looks the removal of IPC one missed? let me update it.

plbossart · 2018-08-10T17:26:10Z

sound/soc/sof/ipc.c

why is this needed? You didn't initialize IPC in the first patches so would this code even be used?

the topology parsing still try to send IPC even neither of dsp and IPC is initialized.
this is hack, let me refine it.

plbossart · 2018-08-10T17:27:41Z

sound/soc/intel/boards/bxt_tdf8532.c

If the DSP is not enabled, we should select another machine driver.

that's true, will change like that.

1. unify to request firmware in ops.load_firmware(). 2. fix request twice issue for skl+ platforms. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Define a new kernel config item SND_SOC_SOF_FORCE_LEGACY_HDA, which depends on SND_SOC_SOF_HDA. To test SOF in legacy HDA mode, we can enable both SND_SOC_SOF_HDA and SND_SOC_SOF_FORCE_LEGACY_HDA. And then SOF will bypass audio DSP and not firmware will be downloaded. Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

…mode Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

…hw_configs is not 1 Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

defined Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

E.g. for snd_hdac_ext_link_clear_stream_id(), we should set (1 << stream) as mask, and 0 as value, here correct it and several similar mismatches. And, here also remove unreadable register_mask usage for those mask value updating. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

keyonjie · 2018-09-12T13:31:00Z

this is outdated, we have already another PR been merged, legacy HDA mode is not ready yet. let me close this one.

…or slabobj_ext When alloc_slab_obj_exts() fails and then later succeeds in allocating a slab extension vector, it calls handle_failed_objexts_alloc() to mark all objects in the vector as empty. As a result all objects in this slab (slabA) will have their extensions set to CODETAG_EMPTY. Later on if this slabA is used to allocate a slabobj_ext vector for another slab (slabB), we end up with the slabB->obj_exts pointing to a slabobj_ext vector that itself has a non-NULL slabobj_ext equal to CODETAG_EMPTY. When slabB gets freed, free_slab_obj_exts() is called to free slabB->obj_exts vector. free_slab_obj_exts() calls mark_objexts_empty(slabB->obj_exts) which will generate a warning because it expects slabobj_ext vectors to have a NULL obj_ext, not CODETAG_EMPTY. Modify mark_objexts_empty() to skip the warning and setting the obj_ext value if it's already set to CODETAG_EMPTY. To quickly detect this WARN, I modified the code from WARN_ON(slab_exts[offs].ref.ct) to BUG_ON(slab_exts[offs].ref.ct == 1); We then obtained this message: [21630.898561] ------------[ cut here ]------------ [21630.898596] kernel BUG at mm/slub.c:2050! [21630.898611] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP [21630.900372] Modules linked in: squashfs isofs vfio_iommu_type1 vhost_vsock vfio vhost_net vmw_vsock_virtio_transport_common vhost tap vhost_iotlb iommufd vsock binfmt_misc nfsv3 nfs_acl nfs lockd grace netfs tls rds dns_resolver tun brd overlay ntfs3 exfat btrfs blake2b_generic xor xor_neon raid6_pq loop sctp ip6_udp_tunnel udp_tunnel nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables rfkill ip_set sunrpc vfat fat joydev sg sch_fq_codel nfnetlink virtio_gpu sr_mod cdrom drm_client_lib virtio_dma_buf drm_shmem_helper drm_kms_helper drm ghash_ce backlight virtio_net virtio_blk virtio_scsi net_failover virtio_console failover virtio_mmio dm_mirror dm_region_hash dm_log dm_multipath dm_mod fuse i2c_dev virtio_pci virtio_pci_legacy_dev virtio_pci_modern_dev virtio virtio_ring autofs4 aes_neon_bs aes_ce_blk [last unloaded: hwpoison_inject] [21630.909177] CPU: 3 UID: 0 PID: 3787 Comm: kylin-process-m Kdump: loaded Tainted: G W 6.18.0-rc1+ thesofproject#74 PREEMPT(voluntary) [21630.910495] Tainted: [W]=WARN [21630.910867] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 [21630.911625] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [21630.912392] pc : __free_slab+0x228/0x250 [21630.912868] lr : __free_slab+0x18c/0x250[21630.913334] sp : ffff8000a02f73e0 [21630.913830] x29: ffff8000a02f73e0 x28: fffffdffc43fc800 x27: ffff0000c0011c40 [21630.914677] x26: ffff0000c000cac0 x25: ffff00010fe5e5f0 x24: ffff000102199b40 [21630.915469] x23: 0000000000000003 x22: 0000000000000003 x21: ffff0000c0011c40 [21630.916259] x20: fffffdffc4086600 x19: fffffdffc43fc800 x18: 0000000000000000 [21630.917048] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 [21630.917837] x14: 0000000000000000 x13: 0000000000000000 x12: ffff70001405ee66 [21630.918640] x11: 1ffff0001405ee65 x10: ffff70001405ee65 x9 : ffff800080a295dc [21630.919442] x8 : ffff8000a02f7330 x7 : 0000000000000000 x6 : 0000000000003000 [21630.920232] x5 : 0000000024924925 x4 : 0000000000000001 x3 : 0000000000000007 [21630.921021] x2 : 0000000000001b40 x1 : 000000000000001f x0 : 0000000000000001 [21630.921810] Call trace: [21630.922130] __free_slab+0x228/0x250 (P) [21630.922669] free_slab+0x38/0x118 [21630.923079] free_to_partial_list+0x1d4/0x340 [21630.923591] __slab_free+0x24c/0x348 [21630.924024] ___cache_free+0xf0/0x110 [21630.924468] qlist_free_all+0x78/0x130 [21630.924922] kasan_quarantine_reduce+0x114/0x148 [21630.925525] __kasan_slab_alloc+0x7c/0xb0 [21630.926006] kmem_cache_alloc_noprof+0x164/0x5c8 [21630.926699] __alloc_object+0x44/0x1f8 [21630.927153] __create_object+0x34/0xc8 [21630.927604] kmemleak_alloc+0xb8/0xd8 [21630.928052] kmem_cache_alloc_noprof+0x368/0x5c8 [21630.928606] getname_flags.part.0+0xa4/0x610 [21630.929112] getname_flags+0x80/0xd8 [21630.929557] vfs_fstatat+0xc8/0xe0 [21630.929975] __do_sys_newfstatat+0xa0/0x100 [21630.930469] __arm64_sys_newfstatat+0x90/0xd8 [21630.931046] invoke_syscall+0xd4/0x258 [21630.931685] el0_svc_common.constprop.0+0xb4/0x240 [21630.932467] do_el0_svc+0x48/0x68 [21630.932972] el0_svc+0x40/0xe0 [21630.933472] el0t_64_sync_handler+0xa0/0xe8 [21630.934151] el0t_64_sync+0x1ac/0x1b0 [21630.934923] Code: aa1803e0 97ffef2b a9446bf9 17ffff9c (d4210000) [21630.936461] SMP: stopping secondary CPUs [21630.939550] Starting crashdump kernel... [21630.940108] Bye! Link: https://lkml.kernel.org/r/20251029014317.1533488-1-hao.ge@linux.dev Fixes: 09c4656 ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations") Signed-off-by: Hao Ge <gehao@kylinos.cn> Reviewed-by: Suren Baghdasaryan <surenb@google.com> Cc: Christoph Lameter (Ampere) <cl@gentwo.org> Cc: David Rientjes <rientjes@google.com> Cc: gehao <gehao@kylinos.cn> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: Shakeel Butt <shakeel.butt@linux.dev> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

plbossart reviewed Aug 10, 2018

View reviewed changes

keyonjie and others added 12 commits August 13, 2018 13:31

ASoC: SOF: refine and cleanup for request_firmware

7c4d24d

1. unify to request firmware in ops.load_firmware(). 2. fix request twice issue for skl+ platforms. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: add pointer callback for dsp_ops

2c361f5

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: HDA: add pcm_pointer callback

3b7dab1

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: apl: add pcm_pointer callback to dsp_ops

748035c

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: HACK to use DPIB position update for hda legacy mode

a36a21b

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: HACK to use coupled mode for hda leagacy

3d70689

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: HACK to disable ipc sending for hda legacy mode

6f2dcae

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: Intel: bxt-tdf8532: add hdmi support

d36b009

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

[HACK]ASoC: SOF: topology: temporary ignore hw_config for legacy hda …

356a728

…mode Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: temporary disable PM as it will lead to calltrace

d75c293

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: intel: clear TCSEL after synchronize_irq

95387e2

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

keyonjie force-pushed the sof-hda-test branch from 199c9b6 to 95387e2 Compare August 17, 2018 06:23

keyonjie added 8 commits August 17, 2018 15:08

ASoC: SOF: topology: only give warning and continue parsing when num_…

7f556f0

…hw_configs is not 1 Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: PCM: do nothing for HDA dai_link fixup()

456e8c3

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: use dsp .pointer() callback if we have when USE_POS_BUF is

caa51af

defined Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: hda-dai: add ops for hda link dais.

71f91bb

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

debug: hack to use bxt_tdf8532 for leafhill hdmi debug

209d6f5

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: hda: replace registers rw with io_ops

599324c

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: hda: request hda irq with different dev_id

992fb07

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

keyonjie closed this Sep 12, 2018

singalsu mentioned this pull request Sep 28, 2018

ASoC: SOF: dont wake dsp up in kcontrol set/get #168

Closed

brentlu mentioned this pull request May 4, 2021

Support Cirrus Logic CS42L42 headphone codec #2884

Merged

Sof hda series for legacy hda mode enabling. #74

Sof hda series for legacy hda mode enabling. #74

Uh oh!

Conversation

keyonjie commented Aug 10, 2018

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonjie commented Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants