Fix ssl3 #97
Fix ssl3 #97
Conversation
|
SOF test PR to test this:thesofproject/sof#5928 |
Fix a misunderstanding with openssl APIs and don't "double sign" the binary. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Ace signing functions need guards for not to use deprecated openssl functions and thus fail the compilation. Openssl3 implementation needs to be done as the added stub now returns just -EINVAL. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
|
Thanks @aiChaoSONG for submitting this to CI in test PR thesofproject/sof#5928. Everyone note how it's possible to submit an unmerged rimage PR to SOF CI, explanations in the rimage README. This bug was incredibly time-consuming: after this is merged and well tested over a couple weeks I think it should be backported to SOF release branches (which will require another bit of submodule-fu) |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
We need to take this for v2.2, and we can readd the MTL support in the correct place for v2.3.
| void *ptr1, unsigned int size1, void *ptr2, | ||
| unsigned int size2) | ||
| { | ||
| return -EINVAL; |
There was a problem hiding this comment.
@juimonen So IIUC, the code that should be here was removed in the previous patch becuase it was in the wrong place and caused FW to be signed twice ?
@mwasko @marcinszkudlinski it looks like we need the MTL code added here, the code is in the wrong place currently, so not new development just a code move and revalidate. Just checking incase you already have this fix ?
There was a problem hiding this comment.
I had an misunderstanding in my own ver25 ssl3 code (first patch), ace functions we're not implemented for ssl3 at all -> I needed to make quick guards and stub (second patch), because git HEAD was not even compiling in systems with ssl3. So just wanted to fix tgl fast, I need to check the ace code later.
There was a problem hiding this comment.
ok, lets merge this as correct SSL3 code and adapt MTL to follow the same flow when using SSL3.
|
@juimonen can you send a PR to udate teh rimage submodule in SOF. Thanks ! |
5 participants
No description provided.