-
Notifications
You must be signed in to change notification settings - Fork 81
[RFC] add mux/demux documentation #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will do in the meantime until the enum kcontrols are done. Do you have an ETA for enums yet ?
|
@lgirdwood updated.
This is now depending on:
I also talk about python blob generator: thesofproject/sof#2536, which people seem not to like, but it is the only "generic" tool we would have to generate blobs... But I can remove this if no traction. So the python tool could be used to generate dc blocker, mux/demux, or even simple eq blobs. And now when I'm on it: we should really do the optimization for demux @Keyon was talking about in thesofproject/sof#2533. Then the demux would be in pretty good shape, so this here looks like mux todo list :) |
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
|
@ranj063 thanks for comments! updated now, hopefully addressed all comments... |
| Example of multiplexer configuration matrices with 2 input streams. | ||
| In this artificial Mux example Input stream 1’s channel 1 is copied | ||
| to both output channels, Input stream 2’s single channel is copied | ||
| also to output channel 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juimonen I'm a newer to mux/demux. And I find it's a little hard for me to understand the picture. Why do we need set column 3, 5, 7 to 1? Shouldn't it be 0s although it doesn't take efforts here. Or we must set 1s in column 3, 5, 7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@libinyang just think as the row as input channel, and 0/1 as if this row (channel) is put to column output channel. so for example first row (0,1,0,1,0,1,0,1) would mean that copy input channel 1 to output channels 2, 4, 6, 8. And so on for other channels. There's always 1 matrix per stream-to-stream mapping.
Hi @juimonen, thanks for the documentation! Only one suggestion that to remove the complicate matrix part if we are aligned to remove the "channel mixing" feature in the future. The good point is that nobody is using that mixing feature until now, so don't mention that could be wise choice, to make easier life not only for people reading this documentation, but also for people who might need to maintain/update the documentation later. |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deb-intel technical approved.
|
@lgirdwood Thanks! |
deb-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I will make grammatical edits in a separate PR.
|
This introduced a number of warnings, at least these: |
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com