logger: Describe runtime logger trace filtration usage #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrzcinx
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
lgirdwood
requested changes
Jun 4, 2020
dbaluta
reviewed
Jun 4, 2020
ktrzcinx
force-pushed
the
runtime-filter
branch
2 times, most recently
from
02a61a7 to
d8cec4e
Compare
lgirdwood
reviewed
Sep 18, 2020
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@deb-intel fyi - just small technical updates needed.
ktrzcinx
force-pushed
the
runtime-filter
branch
from
d8cec4e to
d054bc6
Compare
Each mechanism in logger tool chould be described in sof-dox. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
runtime-filter
branch
from
d054bc6 to
166c2fd
Compare
lgirdwood
approved these changes
Sep 18, 2020
Collaborator
|
@lgirdwood I accidentally sent a request for a new review from you (sorry). Is this PR ready to be merged? |
Member
|
@deb-intel yes, it's ready. thanks ! |
deb-intel
approved these changes
Sep 22, 2020
Collaborator
deb-intel
left a comment
deb-intel
left a comment
There was a problem hiding this comment.
Will make grammatical updates in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each mechanism in logger tool chould be described in sof-dox.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com
Reference changes from thesofproject/sof#2965