Algorithms: Add equalizers design tutorial #417
Conversation
singalsu
requested review from
anton-intel,
deb-intel,
greg-intel,
intelkevinputnam and
lgirdwood
as code owners
singalsu
force-pushed
the
add_equalizers_tutorial
branch
from
f198993 to
cdb599f
Compare
|
@singalsu can you check CI thanks. |
|
I'm not sure how the graphs are constructed, even though the target filter response charts are produced; therefore, a brief explanation of the input type and filter type used would be useful. Thank you !! |
|
The build in https://github.com/thesofproject/sof-docs/runs/7148090318?check_suite_focus=true failed because of... some unrelated doxygen copy/paste from @juimonen , see thesofproject/sof#5731 (comment) Fix submitted in thesofproject/sof#5995, please help review (@juimonen is on vacation) |
|
@lgirdwood Could someone review this please? |
This patch adds a section about measuring acoustical speaker frequency response and design of IIR and FIR equalizers to improve it. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
add_equalizers_tutorial
branch
from
cdb599f to
8817a50
Compare
Did the text leave to you opens? I know it's harder to review markup language with pictures separately, but the text describes the steps done where the plots were created. Executing with some own tuning case the commands should help explain what happens. |
ShriramShastry
left a comment
ShriramShastry
left a comment
There was a problem hiding this comment.
Thank you!!
I'm okay with plot responses.
Ideally, I would conduct my own test and analyse the results.
|
these are great pictures in frequency domain, and very helpful for audio algorithm developers. |
|
|
||
| The settings file | ||
|
|
||
| .. code-block:: bash |
There was a problem hiding this comment.
When the "bash" is used as the language mode for styling while it is just 'cat' followed by a content of a file that uses different language, some strange color styling appears. Might be better to just paste the content and put the file name next it it.
There was a problem hiding this comment.
I wonder if there's a suitable code-block style for generic ASCII stuff. Do you have a recommendation? Just pasting the content without code-block would apply text formatting to it that would mess it up.
There was a problem hiding this comment.
You may replace it with (note the :: at the end of the previous paragraph)
The settings file::
The content of the file (each line indented)
that is not processed and rendered using monospace font.
| psycho-acoustics. Therefore ⅓ octaves should be the smallest feasible | ||
| width of octaves smoothing to use. | ||
|
|
||
| .. figure:: Picture_response_with_smoothing.png |
There was a problem hiding this comment.
It is recommended to use SVG images because 1) they are scalable without loosing a quality and 2) text labels etc. that are part of the graphics are searchable.
There was a problem hiding this comment.
Yep, octave seems to now have svg as option for print. Hopefully also web browsers are OK with it. I will test it for next contribution.
There was a problem hiding this comment.
All plantuml diagrams are already rendered to SVG and I have not seen any issues with web browsers reported.
That could be easily added to EQ tool, e.g. just show the resulting lin or log chirp waveform of the design. It would help to understand the dB -> linear amplitude impact. |
6 participants
This patch adds a section about measuring acoustical speaker
frequency response and design of IIR and FIR equalizers to
improve it.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com