Skip to content

intel_debug: add suggestions for DMIC and ES8336 platforms #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Jul 12, 2022
Merged

intel_debug: add suggestions for DMIC and ES8336 platforms #420

lgirdwood merged 1 commit into from
Jul 12, 2022

Conversation

@plbossart
Copy link
Member

@plbossart plbossart commented Jul 6, 2022

Instead of repeating the same things on GitHub issues, maybe this
documentation will help.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart
Copy link
Member Author

plbossart commented Jul 6, 2022

not checked due to problem on Ubuntu 22.04

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
sphinx-tabs 3.3.1 requires docutils~=0.17.0, but you have docutils 0.16 which is incompatible.

@plbossart plbossart requested review from ranj063 and ujfalusi July 6, 2022 20:45
lgirdwood
lgirdwood reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think @marc-hb has been looking at the recent content generation issues and the pip issue may be related.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 7, 2022

https://github.com/thesofproject/sof-docs/runs/7222607705

I submitted a fix in sof for these 2 doxygen errorsplease help review and expedite: thesofproject/sof#5995

/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:4: WARNING: Duplicate ID: "group__sof__dai__drivers_1ga8c720c310f408b2f97ce014562d6a910".
/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:4: WARNING: Duplicate explicit target name: "group__sof__dai__drivers_1ga8c720c310f408b2f97ce014562d6a910".

/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:6: WARNING: Duplicate declaration, const struct device* dai::drv

(Yes the fix is in sof.git, not in sof-docs.git. It's a doxygen-related issue but it shows only in sphinx/sof-docs)

The other errors clearly come from this PR:

/home/runner/work/sof-docs/sof-docs/getting_started/intel_debug/suggestions.rst:155: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 10 supplied.
.. code-block::
   [    4.301490] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 2

not checked due to problem on Ubuntu 22.04

Exactly why I created this alternative a long time ago, please try it:

pip3 -r scripts/requirements-lax.txt

@plbossart plbossart force-pushed the fix/hdaudio-dmic-bugs branch from ed86d01 to 7e4cdd7 Compare July 7, 2022 13:25
@plbossart
Copy link
Member Author

plbossart commented Jul 7, 2022

pip3 -r scripts/requirements-lax.txt

pip3 -r scripts/requirements-lax.txt

Usage:
pip3 [options]

no such option: -r

???

@plbossart plbossart force-pushed the fix/hdaudio-dmic-bugs branch from 7e4cdd7 to 0b30417 Compare July 7, 2022 16:04
@intelkevinputnam
Copy link
Collaborator

intelkevinputnam commented Jul 7, 2022

pip3 -r scripts/requirements-lax.txt

pip3 -r scripts/requirements-lax.txt

Usage: pip3 [options]

no such option: -r

???

try: pip3 install -r scripts/requirements-lax.txt

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 8, 2022

try: pip3 install -r scripts/requirements-lax.txt

Indeed, sorry for the mistake. I just tried this on Ubuntu 22.04 and it worked 100%

lgirdwood
lgirdwood approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart pip issues resolved now ?

@plbossart
Copy link
Member Author

plbossart commented Jul 8, 2022

@plbossart pip issues resolved now ?

yes, no issues with the 'requirements.lax', the command above was missing a --user switch

marc-hb
marc-hb reviewed Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful!

getting_started/intel_debug/suggestions.rst
platform firmware/NHTL.

There are however a number of hardware configurations that cannot be
detected from platform firmware. To work-around this limitation, the
Copy link
Collaborator

@marc-hb marc-hb Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "platform" firmware?

Copy link
Member Author

@plbossart plbossart Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACPI and others.

marc-hb
marc-hb requested changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting at least the NHTL -> NHLT fixes.

@plbossart
intel_debug: add suggestions for DMIC and ES8336 platforms
b3def46 
Instead of repeating the same things on GitHub issues, maybe this
documentation will help.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart force-pushed the fix/hdaudio-dmic-bugs branch from 0b30417 to b3def46 Compare July 11, 2022 15:07
@plbossart plbossart requested a review from marc-hb July 11, 2022 15:08
@lgirdwood lgirdwood merged commit 99db679 into thesofproject:master Jul 12, 2022
@plbossart
Copy link
Member Author

plbossart commented Jul 18, 2022

Can we please push this to the official docs @lgirdwood @deb-intel ?

@lgirdwood
Copy link
Member

lgirdwood commented Jul 18, 2022

@deb-intel are you able to rebuild and publish this week ? Thanks !

@deb-intel
Copy link
Collaborator

deb-intel commented Jul 18, 2022

@lgirdwood Yes, I can publish by my EOD today.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 18, 2022 •
edited
Loading

@plbossart in general while waiting for https://thesofproject.github.io/latest/index.html you can point people at GitHub in the meantime, for instance this page is rendered and looks very good: https://github.com/thesofproject/sof-docs/blob/master/getting_started/intel_debug/suggestions.rst#es8336-support

@deb-intel
Copy link
Collaborator

deb-intel commented Jul 18, 2022

@lgirdwood The website has been published and includes all merged PRs.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 18, 2022 •
edited
Loading

https://thesofproject.github.io/latest/getting_started/intel_debug/suggestions.html#es8336-support

cc: @MrChromebox

@lgirdwood
Copy link
Member

lgirdwood commented Jul 19, 2022

Thanks @deb-intel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@ujfalusi ujfalusi ujfalusi approved these changes

@marc-hb marc-hb marc-hb approved these changes

@anton-intel anton-intel Awaiting requested review from anton-intel

@deb-intel deb-intel Awaiting requested review from deb-intel deb-intel is a code owner

@intelkevinputnam intelkevinputnam Awaiting requested review from intelkevinputnam intelkevinputnam is a code owner

@greg-intel greg-intel Awaiting requested review from greg-intel

@ranj063 ranj063 Awaiting requested review from ranj063

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@plbossart @marc-hb @intelkevinputnam @lgirdwood @deb-intel @ujfalusi