Skip to content

Conversation

@kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Sep 19, 2023

Add tables documenting the firmare and topology filenames and their
locations, as expected by Linux SOF driver.

Related to ongoing discussions in:

Add note that sof-tgl.ri is just one example firmware file
name.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo and one confusing statement @kv2019i

All good otherwise for me.

@kv2019i kv2019i force-pushed the 202309-sof-fw-tplg-file-layout branch from 0f18d6c to c7333df Compare September 19, 2023 11:53
plbossart
plbossart previously approved these changes Sep 19, 2023
ujfalusi
ujfalusi previously approved these changes Sep 19, 2023
deb-intel
deb-intel previously approved these changes Sep 19, 2023
Copy link
Collaborator

@deb-intel deb-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor grammatical improvements to incorporate.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mengdonglin
mengdonglin previously approved these changes Sep 20, 2023
Add tables documenting the firmare and topology filenames and their
locations, as expected by Linux SOF driver.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202309-sof-fw-tplg-file-layout branch from 706101a to b959e84 Compare September 20, 2023 07:12
@kv2019i
Copy link
Contributor Author

kv2019i commented Sep 20, 2023

Thanks for reviews. @deb-intel and @marc-hb I merged your wording suggestions to a new version.

@marc-hb marc-hb merged commit 3c934c7 into thesofproject:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants