Skip to content

Conversation

@ujfalusi
Copy link
Contributor

SOF supports platforms from Tiger Lake with IPC4, update the docuementation accordingly.

Update the MTL/LNL topology path to follow a generic pattern and add a note about the need for a symlink for the old path to retain backwards compatibility with released kernels.

SOF supports platforms from Tiger Lake with IPC4, update the docuementation
accordingly.

Update the MTL/LNL topology path to follow a generic pattern and add a note
about the need for a symlink for the old path to retain backwards
compatibility with released kernels.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart good for you ?

@lgirdwood lgirdwood merged commit f70388a into thesofproject:master Oct 20, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Dec 30, 2023

@perexg , @mrhpearson, @andyross : /lib/firmware/intel/ heads-up

@mrhpearson
Copy link

@perexg , @mrhpearson, @andyross : /lib/firmware/intel/ heads-up

Thanks! So this should be done with the 2023.12 release then? I've released the debian package for that and haven't implemented the symlink from sof-ace-tplg to sof-ipc4-tplg there.
I'm a bit confused by the backwards compatibility comment as, to my knowledge, Meteorlake audio isn't working with currently released kernels (pre 6.7) so I'm wondering if this is really a no-op?
Let me know if I need to update the deb package or if it's just something that can be done for the next release.

As a side note, audio with 2023.12 is running on my Meteorlake X1 Carbon G12, with a 6.7 rc7 kernel, well (only just got the machine yesterday though....so still setting it up and playing with it)

- CONFIG = topology variant needed for detected hardware configuration

Important notices:
- For compatibility reasons for **Meteor Lake and newer** ``/lib/firmware/intel/sof-ace-tplg`` must be symlinked to ``/lib/firmware/intel/sof-ipc4-tplg``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb @ujfalusi Just for the records, SOF-2.8 and sof-bin-2023.12 releases do NOT follow this yet, so not sure we can depend on this (as the multipple releases are already out which are NOT following this).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i, see my proposal at thesofproject/sof#8683 (comment)

I will create an update for the docs, then I will also add a --deployable-build flag to the topology building to create the structure under tools/build_tools/topology/target/ for easy packaging, deployment. Then we can update the sof-bin.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I will also add a --deployable-build flag to the topology building to create the structure under tools/build_tools/topology/target/ for easy packaging, deployment.

Unlike IPC4 firmware, the directory structure of topologies was always supposed to be: 1. simple, 2. deployable. Also, there's no python script that you can easily hack for topologies, it's just CMake and moving some directories. Let's please not create a new script there: if some topologies are in the wrong directory then just move them in git.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are in correct directories in terms of separation, the names are not that great fort he future, I would prefer a script to move them out or rename them:
tools/topology/topology2/avs-tplg -> tools/topology/topology2/cavs2.5
tools/topology/topology2/sof-ace-tplg -> tools/topology/topology2/ace1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/topology/topology2/avs-tplg -> tools/topology/topology2/cavs2.5
tools/topology/topology2/sof-ace-tplg -> tools/topology/topology2/ace1

As long as file contents stay identical git is pretty good at tracking files across renames. So if you think renaming these directories helps then please just go and do it.

@kv2019i
Copy link
Contributor

kv2019i commented Jan 2, 2024

@marc-hb wrote:

@perexg , @mrhpearson, @andyross : /lib/firmware/intel/ heads-up

So no change in the short term. If we need to have symlinks, those need to be in sof-bin releases first.

We also need to solve the issue of platform specific tplgs first before we can merge sof-ace-tplg and sof-ipc4-tplg -> thesofproject/sof#8683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants