-
Notifications
You must be signed in to change notification settings - Fork 80
intel_debug: introduction: Update for pathnames for IPC4 support #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intel_debug: introduction: Update for pathnames for IPC4 support #476
Conversation
SOF supports platforms from Tiger Lake with IPC4, update the docuementation accordingly. Update the MTL/LNL topology path to follow a generic pattern and add a note about the need for a symlink for the old path to retain backwards compatibility with released kernels. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plbossart good for you ?
|
@perexg , @mrhpearson, @andyross : /lib/firmware/intel/ heads-up |
Thanks! So this should be done with the 2023.12 release then? I've released the debian package for that and haven't implemented the symlink from sof-ace-tplg to sof-ipc4-tplg there. As a side note, audio with 2023.12 is running on my Meteorlake X1 Carbon G12, with a 6.7 rc7 kernel, well (only just got the machine yesterday though....so still setting it up and playing with it) |
| - CONFIG = topology variant needed for detected hardware configuration | ||
|
|
||
| Important notices: | ||
| - For compatibility reasons for **Meteor Lake and newer** ``/lib/firmware/intel/sof-ace-tplg`` must be symlinked to ``/lib/firmware/intel/sof-ipc4-tplg`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i, see my proposal at thesofproject/sof#8683 (comment)
I will create an update for the docs, then I will also add a --deployable-build flag to the topology building to create the structure under tools/build_tools/topology/target/ for easy packaging, deployment. Then we can update the sof-bin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then I will also add a --deployable-build flag to the topology building to create the structure under tools/build_tools/topology/target/ for easy packaging, deployment.
Unlike IPC4 firmware, the directory structure of topologies was always supposed to be: 1. simple, 2. deployable. Also, there's no python script that you can easily hack for topologies, it's just CMake and moving some directories. Let's please not create a new script there: if some topologies are in the wrong directory then just move them in git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are in correct directories in terms of separation, the names are not that great fort he future, I would prefer a script to move them out or rename them:
tools/topology/topology2/avs-tplg -> tools/topology/topology2/cavs2.5
tools/topology/topology2/sof-ace-tplg -> tools/topology/topology2/ace1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/topology/topology2/avs-tplg -> tools/topology/topology2/cavs2.5
tools/topology/topology2/sof-ace-tplg -> tools/topology/topology2/ace1
As long as file contents stay identical git is pretty good at tracking files across renames. So if you think renaming these directories helps then please just go and do it.
|
@marc-hb wrote:
So no change in the short term. If we need to have symlinks, those need to be in sof-bin releases first. We also need to solve the issue of platform specific tplgs first before we can merge sof-ace-tplg and sof-ipc4-tplg -> thesofproject/sof#8683 |
SOF supports platforms from Tiger Lake with IPC4, update the docuementation accordingly.
Update the MTL/LNL topology path to follow a generic pattern and add a note about the need for a symlink for the old path to retain backwards compatibility with released kernels.