Skip to content

Catch firmware errors #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredoh9 merged 2 commits into from
Apr 23, 2024
Merged

Catch firmware errors #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc580c5
lib.sh: warn about HTML bug hiding zephyr log levels
marc-hb Jul 1, 2023
2825652
hijack.sh: fail when an error is found in Zephyr firmware logs
marc-hb Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions case-lib/hijack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ function func_exit_handler()
dloge "Empty logfile"
exit_status=1
fi

# We still have some false positives in stable-v2.2 for now, see
# https://github.com/thesofproject/sof-test/pull/1075
# https://github.com/thesofproject/sof/pull/9036
# etc.
if is_firmware_file_zephyr; then

check_error_in_fw_logfile "$logfile" ||
exit_status=1

fi

else
dloge "Log file not found: $logfile"
exit_status=1
Expand Down
5 changes: 4 additions & 1 deletion case-lib/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,10 @@ check_error_in_fw_logfile()
if (set -x
grep -B 2 -A 1 -i --word-regexp -e 'ERR' -e 'ERROR' -e '<err>' "$1"
); then
return 1
# See internal Intel bug #448
dlogw 'An HTML display bug hides the bracketed Zephyr &lt;loglevels&gt; in this tab,'
dlogw 'switch to the tab with the complete logs to see the log levels.'
return 1
fi
}

Expand Down